Fix low pass filter sometimes not applied in dialog overlays

ppy · Jun 28, 2024 · 77b00da · 77b00da
1 parent 1668048
commit 77b00da
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/osu.Game/Overlays/Dialog/PopupDialogDangerousButton.cs b/osu.Game/Overlays/Dialog/PopupDialogDangerousButton.cs
@@ -3,6 +3,7 @@
 
 #nullable disable
 
+using System;
 using osu.Framework.Allocation;
 using osu.Framework.Audio;
 using osu.Framework.Audio.Sample;
@@ -71,7 +72,7 @@ private void load(AudioManager audio)
             protected override void LoadComplete()
             {
                 base.LoadComplete();
-                Progress.BindValueChanged(progressChanged);
+                Progress.BindValueChanged(progressChanged, true);
             }
 
             protected override void AbortConfirm()
@@ -122,11 +123,13 @@ protected override void OnHoverLost(HoverLostEvent e)
 
             private void progressChanged(ValueChangedEvent<double> progress)
             {
-                if (progress.NewValue < progress.OldValue) return;
+                lowPassFilter.Cutoff = Math.Max(1, (int)(progress.NewValue * AudioFilter.MAX_LOWPASS_CUTOFF * 0.5));
 
-                if (Clock.CurrentTime - lastTickPlaybackTime < 30) return;
+                if (progress.NewValue < progress.OldValue)
+                    return;
 
-                lowPassFilter.CutoffTo((int)(progress.NewValue * AudioFilter.MAX_LOWPASS_CUTOFF * 0.5));
+                if (Clock.CurrentTime - lastTickPlaybackTime < 30)
+                    return;
 
                 var channel = tickSample.GetChannel();