Skip to content

Commit

Permalink
Merge pull request #21059 from peppy/fix-combo-colour-application
Browse files Browse the repository at this point in the history
Fix `DrawableHitObject.AccentColour` not being updated if object entry is not attached
  • Loading branch information
smoogipoo authored Nov 1, 2022
2 parents 947e6d4 + f014acf commit 3fa529c
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,10 @@ protected sealed override void OnApply(HitObjectLifetimeEntry entry)
updateState(ArmedState.Miss, true);
else
updateState(ArmedState.Idle, true);

// Combo colour may have been applied via a bindable flow while no object entry was attached.
// Update here to ensure we're in a good state.
UpdateComboColour();
}
}

Expand Down

0 comments on commit 3fa529c

Please sign in to comment.