Merge pull request #30984 from smoogipoo/fix-mania-spinner-conversion

Fix "spinner" conversion for mania-specific beatmaps
ppy · Dec 19, 2024 · 1057aa8 · 1057aa8
2 parents 9cdf06b + d597232
commit 1057aa8
Show file tree

Hide file tree

Showing 17 changed files with 1,730 additions and 156 deletions.
diff --git a/osu.Game.Rulesets.Mania.Tests/ManiaBeatmapConversionTest.cs b/osu.Game.Rulesets.Mania.Tests/ManiaBeatmapConversionTest.cs
@@ -22,9 +22,11 @@ public class ManiaBeatmapConversionTest : BeatmapConversionTest<ManiaConvertMapp
 
         [TestCase("basic")]
         [TestCase("zero-length-slider")]
+        [TestCase("mania-specific-spinner")]
         [TestCase("20544")]
         [TestCase("100374")]
         [TestCase("1450162")]
+        [TestCase("4869637")]
         public void Test(string name) => base.Test(name);
 
         protected override IEnumerable<ConvertValue> CreateConvertValue(HitObject hitObject)

diff --git a/osu.Game.Rulesets.Mania.Tests/Resources/Testing/Beatmaps/4869637-expected-conversion.json b/osu.Game.Rulesets.Mania.Tests/Resources/Testing/Beatmaps/4869637-expected-conversion.json