Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Play Styles Stubs #3713

Merged
merged 30 commits into from
Aug 31, 2020
Merged

Create Play Styles Stubs #3713

merged 30 commits into from
Aug 31, 2020

Conversation

MilkyIQ
Copy link
Contributor

@MilkyIQ MilkyIQ commented Jun 17, 2020 •
edited
Loading

Resolves part of #3149; part of overall organization effort #3143.

Creates stubs for the following topics:

  • Single-tapping
  • Alternating
  • Double Tapping
  • Hybrid
  • Tapx
  • Tapping style

MilkyIQ added 10 commits June 15, 2020 17:26
@MilkyIQ
Create Play Styles Stubs
ca099e4 
Creates a stub for single-tapping

### To-Do:
- [ ] Add link to alternating stub
- [ ] Add link to double tapping stub
@MilkyIQ
Create Alternating Stub
050fa99 
Creates a stub for alternating
@MilkyIQ
Create Double Tapping stub
b469a7d 
Creates a stub article for Double Tapping. It'll eventually need a link for a stub and/or full-fledged article that explains the term "hit window"
@MilkyIQ
Create Hybrid stub
d573644
@MilkyIQ
Create Tapx stub
87fe141
@MilkyIQ
Cleanup Single-tap
963dff6
@MilkyIQ
Cleanup Alternating
fadd965
@MilkyIQ
Cleanup Double Tapping
f39a923
@MilkyIQ
Cleanup Hybrid
1ead79c
@MilkyIQ
Cleanup Tapx
ebd1747
@Loctav Loctav mentioned this pull request Jun 17, 2020
Closed
35 tasks
MilkyIQ added 6 commits June 19, 2020 17:38
@MilkyIQ
Rename Single-tapping to Single_tapping
55b06f8
@MilkyIQ
Update en.md
266b0c4
@MilkyIQ
Merge pull request #11 from paper-toaster/test-branch
3a34258 
remarkjs error test
@MilkyIQ
Undo empty line
319e24c
@MilkyIQ
test remarkjs error
6929a37
@MilkyIQ
Minor Formatting Fixes (#14)
348610e 
* Minor Formatting Fixes

* Minor Formatting Fixes

* Minor Formatting Fixes

* Minor Formatting Fixes

* Minor Formatting Fixes
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 26, 2020
MilkyIQ
MilkyIQ commented Jul 9, 2020
View reviewed changes
Copy link
Contributor Author

@MilkyIQ MilkyIQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too lazy to create a new branch on web so i suggested changes to my own pr

wiki/Play_Styles/Alternating/en.md Outdated Show resolved Hide resolved
wiki/Play_Styles/Double_Tapping/en.md Outdated Show resolved Hide resolved
wiki/Play_Styles/Hybrid/en.md Outdated Show resolved Hide resolved
wiki/Play_Styles/Singletapping/en.md Outdated Show resolved Hide resolved
wiki/Play_Styles/Tapx/en.md Outdated Show resolved Hide resolved
@MegaApplePi MegaApplePi self-requested a review July 14, 2020 03:07
@MegaApplePi MegaApplePi self-assigned this Aug 11, 2020
MegaApplePi
MegaApplePi requested changes Aug 11, 2020
View reviewed changes
wiki/Play_Styles/Alternating/en.md Outdated Show resolved Hide resolved
@MegaApplePi MegaApplePi removed their assignment Aug 20, 2020
@MegaApplePi MegaApplePi self-requested a review August 20, 2020 00:16
@MegaApplePi MegaApplePi self-assigned this Aug 30, 2020
@MegaApplePi MegaApplePi merged commit fce4a50 into ppy:master Aug 31, 2020
@MilkyIQ MilkyIQ deleted the play-styles-stubs branch December 2, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaApplePi MegaApplePi MegaApplePi approved these changes

Assignees

@MegaApplePi MegaApplePi

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MilkyIQ @MegaApplePi @Joehuu