Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C lettered article stubs from glossary #3505

Merged
merged 10 commits into from
Aug 30, 2020
Merged

Add C lettered article stubs from glossary #3505

merged 10 commits into from
Aug 30, 2020

Conversation

Pennek
Copy link
Contributor

@Pennek Pennek commented Apr 29, 2020 •
edited
Loading

Effort to organize ala #3143

Adds articles:

  • Changelog
  • Choke/Reverse Choke
  • Combo (Multiplier Effect)
  • Combocolour
  • Colourhaxing
  • Combo Fire
  • Combo Milestone
  • Combo Multiplier Effect
  • Combobreak
  • Comboburst
  • Cookie

Modifies articles:

  • Combo (Comboset)

MilkyIQ
MilkyIQ suggested changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@MilkyIQ MilkyIQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good overall. Just needed some TLC with formatting and links. I also added some extra info where applicable.

wiki/Beatmapping/Colourhaxing/en.md Outdated Show resolved Hide resolved
wiki/Beatmapping/Combo/en.md Outdated Show resolved Hide resolved
wiki/Glossary/Changelog/en.md Outdated Show resolved Hide resolved
wiki/Glossary/Choke/en.md Outdated Show resolved Hide resolved
wiki/Glossary/Combo_Colour/en.md Outdated Show resolved Hide resolved
wiki/Glossary/Comboburst/en.md Outdated Show resolved Hide resolved
wiki/Glossary/Comboburst/en.md Outdated Show resolved Hide resolved
wiki/Glossary/Comboburst/en.md Outdated Show resolved Hide resolved
wiki/Glossary/Comboburst/en.md Outdated Show resolved Hide resolved
wiki/Glossary/Cookie/en.md Outdated Show resolved Hide resolved
@cl8n cl8n added this to the July 2020 milestone Jul 2, 2020
@Pennek Pennek mentioned this pull request Jul 5, 2020
Closed
24 tasks
@MegaApplePi
Copy link
Contributor

Combo can probably be a disambiguation page.

MilkyIQ
MilkyIQ reviewed Aug 3, 2020
View reviewed changes
Copy link
Contributor

@MilkyIQ MilkyIQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just passing by

wiki/Beatmapping/Combo/en.md Outdated Show resolved Hide resolved
wiki/Glossary/Combo_(score_multiplier)/en.md Show resolved Hide resolved
@MegaApplePi MegaApplePi self-requested a review August 20, 2020 00:17
@MegaApplePi MegaApplePi self-assigned this Aug 30, 2020
@MegaApplePi MegaApplePi merged commit 84e7eb4 into ppy:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilkyIQ MilkyIQ MilkyIQ requested changes

@MegaApplePi MegaApplePi MegaApplePi approved these changes

Assignees

@MegaApplePi MegaApplePi

Labels
None yet
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.
4 participants
@Pennek @MegaApplePi @MilkyIQ @cl8n