Update forum-related factories, seeder, and tests #8641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use class factories & more sane attributes/states/etc
notbakaneko
requested changes
Mar 8, 2022
notbakaneko
requested changes
Oct 28, 2022
Not useful to use this factory by itself
notbakaneko
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was originally going to be just the factories but I couldn't help tidying up everything else I saw along the way of replacing factory usage
ForumSeederis completely rewritten. tests are just cleaned up a little and using the new factories, but make all the same assertions as before. except I also removedForumTopicsControllerTest::testDestroybecause it doesn't do what it says it does and duplicatestestReply🤔