Fix page scrolling when typing into new discussions text box #10621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typing into it triggers scrolling into view and scroll-padding doesn't quite behave the way we want to with position sticky
nanaya
requested changes
Oct 6, 2023
| @@ -357,6 +358,10 @@ export class Main extends React.PureComponent | |||
| @cache.groupedBeatmaps ?= BeatmapHelper.group _.values(@beatmaps()) | |||
|
|
|||
|
|
|||
| handleNewDiscussionFocus: => | |||
| document.documentElement.style.removeProperty '--scroll-padding-top-extra' | |||
There was a problem hiding this comment.
can use a note it's for this chrome (and safari) bug
There was a problem hiding this comment.
actually forgot to put a comment after figuring out the cutoffs where the scrolling starts 👀
nanaya
approved these changes
Oct 6, 2023
…xtra-on-sticky-focus
notbakaneko
deleted the
feature/discussions-unset-scroll-padding-extra-on-sticky-focus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
position: stickyandscroll-paddingdon't quite behave well together.Typing into the text area or selecting text constantly triggers scrolling into view and the combination of
position: stickyandscroll-paddingmakes the entire page scroll; this doesn't happen if the totalscroll-padding-topis less vertical position where it's focusing into view (which it normally isn't).closes #10578