Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix migrations with dependencies failing if run by themselves #10461

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Fix migrations with dependencies failing if run by themselves #10461

merged 3 commits into from
Aug 15, 2023

Conversation

cl8n
Copy link
Member

@cl8n cl8n commented Aug 14, 2023

random problem i found while testing #10454. see 2016_10_28_000000_update_oauth_tables for example

nanaya
nanaya requested changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@nanaya nanaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won't be useful going forward. I'd rather update the related migrations to be in the new format and have them imported as needed ((include $migration)->down() etc)

@cl8n cl8n force-pushed the fix-dependent-migrations branch from 1fd5f10 to 97ea074 Compare August 14, 2023 21:09
@cl8n cl8n requested a review from nanaya August 14, 2023 21:12
nanaya
nanaya requested changes Aug 15, 2023
View reviewed changes
app/helpers.php Outdated Show resolved Hide resolved
@nanaya nanaya merged commit 4453472 into ppy:master Aug 15, 2023
@cl8n cl8n deleted the fix-dependent-migrations branch August 15, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanaya nanaya nanaya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cl8n @nanaya