Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up group page variant of UserList component #10444

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Clean up group page variant of UserList component #10444

merged 3 commits into from
Aug 24, 2023

Conversation

cl8n
Copy link
Member

@cl8n cl8n commented Aug 7, 2023

pass in the group rather than splitting into a bunch of related props

@cl8n cl8n mentioned this pull request Aug 7, 2023
Draft
2 tasks
nanaya
nanaya approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@nanaya nanaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if all that useful but sure I guess 🤷 (if anything this makes the component less flexible with title and description only available for group page but nothing else is using it atm either so)

@nanaya nanaya enabled auto-merge August 24, 2023 12:13
@nanaya nanaya merged commit 17e7c1e into ppy:master Aug 24, 2023
@cl8n cl8n deleted the user-list-group-page branch August 24, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanaya nanaya nanaya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cl8n @nanaya