Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back iOS application delegates and fix many issues #6453

Merged
merged 5 commits into from
Dec 15, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't disable UIKit event pump ever
Disabling UIKit event pump prevents the app from receiving general app notifications. See: https://github.com/libsdl-org/SDL/blob/45fc548562d7313e0066b99ca7279935e90e4fb1/src/video/uikit/SDL_uikitevents.m#L52-L66
frenzibyte committed Dec 11, 2024

Verified

This commit was signed with the committer’s verified signature.
WenyXu Weny Xu
commit 3ef75423996bba4ca71552bb1ebf34d80e371234
2 changes: 0 additions & 2 deletions osu.Framework.iOS/IOSWindow.cs
Original file line number Diff line number Diff line change
@@ -62,8 +62,6 @@ protected override unsafe void RunMainLoop()
// iOS may be a good forward direction if this ever comes up, as a user may see a potentially higher
// frame rate with multi-threaded mode turned on, but it is going to give them worse input latency
// and higher power usage.

SDL_SetiOSEventPump(false);
SDL_SetiOSAnimationCallback(SDLWindowHandle, 1, &runFrame, ObjectHandle.Handle);
}


Unchanged files with check annotations Beta

{
public static class Application
{
public static void Main(string[] args) => GameApplication.Main(new TemplateGameGame());

Check failure on line 11 in osu.Framework.Templates/templates/template-empty/TemplateGame.iOS/Application.cs

GitHub Actions / Build only (iOS)

The name 'GameApplication' does not exist in the current context

Check failure on line 11 in osu.Framework.Templates/templates/template-empty/TemplateGame.iOS/Application.cs

GitHub Actions / Build only (iOS)

The name 'GameApplication' does not exist in the current context
}
}
{
public static class Application
{
public static void Main(string[] args) => GameApplication.Main(new FlappyDonGame());

Check failure on line 8 in osu.Framework.Templates/templates/template-flappy/FlappyDon.iOS/Application.cs

GitHub Actions / Build only (iOS)

The name 'GameApplication' does not exist in the current context

Check failure on line 8 in osu.Framework.Templates/templates/template-flappy/FlappyDon.iOS/Application.cs

GitHub Actions / Build only (iOS)

The name 'GameApplication' does not exist in the current context
}
}