Remove closure allocations in VeldridStagingTexturePool #6373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
approved these changes
Sep 10, 2024
|
Sorry for commenting on closed PRs, but I'm curious: what tool are you using to profile memory allocations like in the attached screenshot? I'm not familiar with memory profiling so I'd love to know more. |
|
https://www.jetbrains.com/dotmemory It's part of JetBrains Rider these days, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to not overcomplicate this one too much.
Over about 10 seconds idle with frame time statistics graphs open: