Fix WaveformGraph overhead when DrawPosition is changed
#6009
Conversation
The previous attempt to fix this (ppy#5197) helped, but there were still some scenarios where invalidation would cause regeneration. Let's just do our own invalidation for now. One thing I'm not sure about is whether checking `DrawSize` here is enough (should I be using `ScreenSpaceDrawQuad.Size` instead?).
| // We should regenerate when `Scale` changed, but not `Position`. | ||
| // Unfortunately both of these are grouped together in `MiscGeometry`. | ||
| // Can't use invalidation for this as RequiredParentSizeToFit is closes, but also triggers on DrawPosition changes. | ||
| if (lastGeneratedDrawSize != null && DrawSize != lastGeneratedDrawSize) | ||
| queueRegeneration(); |
There was a problem hiding this comment.
The comment previously mentioned scale, but that's not included in DrawSize. Perhaps it makes more sense this way, though? That is - when we think of scale it's usually in the context of stretching data and not generating new data for the stretched bounds?
There was a problem hiding this comment.
RequiredParentSizeToFit = MiscGeometry | DrawSize. MiscGeometry invalidates on Scale, so the comment made sense. I don't necessarily disagree with ignoring it though as you say.
Yeah it's subtle. See the spikes on the update thread, which occur every beat in the editor. |
|
As a side note, Can there maybe be a |
To speed things up I'm just gonna leave that for the next time we touch that I think. Or a separate PR. |
The previous attempt to fix this (#5197) helped, but there were still some scenarios where invalidation would cause regeneration.
Let's just do our own invalidation for now.
One thing I'm not sure about is whether checking
DrawSizehere is enough (should I be usingScreenSpaceDrawQuad.Sizeinstead?).Closes ppy/osu#24951