Add new DeferredStagingBuffer type
#5838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
reviewed
Jun 13, 2023
| { | ||
| case GraphicsBackend.Direct3D11: | ||
| case GraphicsBackend.Vulkan: | ||
| return new PersistentStagingBuffer<T>(this, count); |
There was a problem hiding this comment.
To confirm, this is changing d3d back to persistent in a hope that the corruption was a fluke / is fixed? And the new deferred buffer is a fallback for users to potentially test if corruption does come back?
There was a problem hiding this comment.
This is not changing D3D/Vulkan.
And the new deferred buffer is a fallback for users to potentially test if corruption does come back?
Correct.
peppy
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On occasion, I have noticed the new
PersistentStagingBuffercausing graphics corruption. At least, I think it's because of this type and its undefined nature (part of the reason why we now have anUnmap()inside the copy function).As a result, I'm going back to buffers to figure out the most efficient update strategy. This implements a new
DeferredStagingBuffer, which uses a managed CPU buffer and an intermediate driver-sideStagingbuffer, to do updates.The new type is off by default, and is only accessible with an environment variable:
OSU_GRAPHICS_STAGING_BUFFER_TYPE0=ManagedStagingBuffer1=PersistentStagingBuffer2=DeferredStagingBufferI'd like to test this new type over time, with the intent of it replacing
PersistentStagingBuffer. I'm currently unable to reproduce the graphics corruption I was seeing previously, so I intend to be able to reproduce that once more first to see whether it was a fluke.ManagedStagingBufferManagedStagingBufferPersistentStagingBufferPersistentStagingBufferDeferredStagingBufferDeferredStagingBuffer