-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IRenderer
and adjust DrawNode
signature
#5324
Conversation
No issues with the code changes in this PR, but:
Do you have an example of a case like this? I couldn't find any in the diff, and I'm not sure what the |
The Examples of this are in the osu!-side PR, where I’ve removed the parameter. |
Hmm, even looking at the osu! side changes I can't see where this advice would apply. Can you link an example line? |
For a view of the full changes: smoogipoo#88
IRenderer
interface.IRenderer
to theDrawNode
method signatures.GLWrapper
for now. This isn't the final location, but is needed for the time being due to the wayTextureGLSingle
works.ClearInfo
/MaskingInfo
/DepthInfo
drawing structs.vNext
IRenderer
added as parameter toDrawNode
In places where the
vertexAction
parameter was used, passnull
instead.ClearInfo
,MaskingInfo
,DepthInfo
have been re-namespacedThe new namespace is
osu.Framework.Graphics.Rendering
.