Android input handlers refactor #5317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
reviewed
Jul 20, 2022
| @@ -30,6 +31,8 @@ public abstract class AndroidInputHandler : InputHandler | |||
| /// </summary> | |||
| protected readonly AndroidGameView View; | |||
|
|
|||
| public override string Description => base.Description.Replace("Android", null); | |||
There was a problem hiding this comment.
This reads a bit weird. Is this to make things display correctly in settings?
There was a problem hiding this comment.
Settings use custom LocalizabeStrings instead of this.
This is used when logging unhandled events and takes inspiration from InputHandler.Description:
There was a problem hiding this comment.
Can we just leave the Android in the description? If it's not displayed anywhere else, I think I'd prefer it being there in logs.
There was a problem hiding this comment.
In that case, the Description can stay as-is, but logs will use GetType().ReadableName()
There was a problem hiding this comment.
Still a bit confused here. Can we revert the Replace part?
1 task
Adds complexity and is not really used anywhere, as some of the handlers override it.
peppy
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
FrameStatisticswhen enqueuing inputTouchSourcevalidation for touch inputHistoric handling of touch input
Explainer: https://developer.android.com/reference/android/view/MotionEvent#batching
This is especially important if the game/device is lagging. Previously we were dropping a lot of events. I expect the UI to feel marginally smoother with historic handling, and scrolling/dragging to be more precise.