Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Resharper inspections fail the CI job #4514

Merged
merged 5 commits into from
Jun 16, 2021
Merged

Make Resharper inspections fail the CI job #4514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79dd06a
Add inspection error
smoogipoo Jun 15, 2021
2255f83
Use custom NVika build for inspectcode reports
smoogipoo Jun 15, 2021
a279645
Upgrade to 1.0.1
smoogipoo Jun 15, 2021
c158346
Revert "Add inspection error"
smoogipoo Jun 15, 2021
88def79
Merge branch 'master' into fix-resharper-ci
peppy Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .config/dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
"jb"
]
},
"nvika": {
"version": "2.0.0",
"smoogipoo.nvika": {
"version": "1.0.1",
"commands": [
"nvika"
]
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,5 @@ jobs:
- name: InspectCode
run: dotnet jb inspectcode $(pwd)/osu-framework.Desktop.slnf --output=$(pwd)/inspectcodereport.xml --cachesDir=$(pwd)/inspectcode --verbosity=WARN

- name: ReSharper
uses: glassechidna/resharper-action@master
with:
report: ${{github.workspace}}/inspectcodereport.xml
- name: NVika
run: dotnet nvika parsereport "${{github.workspace}}/inspectcodereport.xml" --treatwarningsaserrors