Created parameter to build or not from source using mingw #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to verify that this change won't affect our current usage. I do not believe that it will but we need to verify. p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @vijaytripathi, @ppouliot,
This PR contains a new parameter to
nova_dependencies.ppcalled$build_from_source(better name?) that gets its default value fromparams.pp. My idea is to use this flag as a trigger for the new bits using MinGw.I've set
falseas its default value until the whole functionality is finished. Let me know if you prefer to keep this valuetrueby default or fetch it from hiera (and I'll update the commit).