Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

back-to-top feature with a problem #554

Closed
2 tasks done
ShuaiJunlan opened this issue Nov 12, 2019 · 4 comments
Closed
2 tasks done

back-to-top feature with a problem #554

ShuaiJunlan opened this issue Nov 12, 2019 · 4 comments
Labels
discussion Any questions about this theme.

Comments

@ShuaiJunlan
Copy link

ShuaiJunlan commented Nov 12, 2019

Please make sure you took care of the following things before you submit this issue. Thank you!

When I click the back-to-top button, the chrome browser open a new blank tab page.
You can reproduce this problem by visiting this url (https://blog.shuaijunlan.cn/2019/02/27/leetcode-single-number/#References) and clicking the back-to-top button.

I am using the 2.6.1 release version of hexo-theme-icarus.

@ppoffice
Copy link
Owner

ppoffice commented Nov 12, 2019

@ShuaiJunlan There's a breaking change in Hexo 4.0.0. Please use the latest master branch of Hexo or update your root _config.yml.

hexojs/hexo#3812
https://github.com/ppoffice/hexo-theme-icarus/blob/site/_config.yml#L34-L36

@ppoffice ppoffice added the discussion Any questions about this theme. label Nov 12, 2019
@kosuke-zhang
Copy link

kosuke-zhang commented Nov 12, 2019

@ShuaiJunlan There's a breaking change in Hexo 4.0.0. Please use the latest master branch.

remove href="javascript:;" can solve it from back-to-top.ejs

截屏2019-11-13上午1 34 58

kosuke-zhang pushed a commit to kosuke-zhang/hexo-theme-icarus that referenced this issue Nov 12, 2019
@ppoffice
Copy link
Owner

ppoffice commented Nov 12, 2019

@ShuaiJunlan No need to remove that. This bug is fixed in a recent pull request of Hexo.

hexojs/hexo#3812

@ShuaiJunlan
Copy link
Author

I have solved this problem. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Any questions about this theme.
Projects
None yet
Development

No branches or pull requests

3 participants