Fixing hacks fixed by elastic#10175

ppisljar · Feb 24, 2017 · 7aa6e14 · 7aa6e14
1 parent 9ff5256
commit 7aa6e14
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 24 deletions.
diff --git a/src/core_plugins/metrics/public/kbn_vis_types/editor_controller.js b/src/core_plugins/metrics/public/kbn_vis_types/editor_controller.js
@@ -18,25 +18,6 @@ app.controller('MetricsEditorController', (
   const fetch = Private(require('../lib/fetch'));
   const fetchFields = Private(require('../lib/fetch_fields'));
 
-  const globalNavUnsub = $scope.$watch(() => {
-    return globalNavState.isOpen();
-  }, newValue => {
-    if (newValue) {
-      $scope.editorWidth = '180px';
-    } else {
-      $scope.editorWidth = '53px';
-    }
-  });
-
-  $scope.editorTop = '70px';
-  $scope.$watch(() => {
-    return $('.toaster-container').length && $('.toaster-container').height() || 0;
-  }, newValue => {
-    $scope.editorTop = `${newValue + 70}px`;
-  });
-
-  $scope.$on('$destory', globalNavUnsub);
-
   const debouncedFetch = _.debounce(() => {
     fetch($scope)();
   }, 300, {

diff --git a/src/core_plugins/metrics/public/kbn_vis_types/index.js b/src/core_plugins/metrics/public/kbn_vis_types/index.js
@@ -21,6 +21,7 @@ export default function MetricsVisProvider(Private) {
         for creating visualizations for time series based metrics using the
         powerful pipeline aggs Elasticsearch feature`,
     template: require('./vis.html'),
+    fullEditor: true,
     params: {
       editor: require('./editor.html')
     },

diff --git a/src/core_plugins/metrics/public/less/editor.less b/src/core_plugins/metrics/public/less/editor.less
@@ -2,11 +2,6 @@
 
 .vis_editor_container {
   background: @pageColor;
-  position: fixed;
-  top: 70px;
-  right: 0;
-  bottom: 0;
-  overflow: auto;
 }
 
 // general styles