Skip to content

Commit

Permalink
CI: Remove disabling seccomp for a container manager
Browse files Browse the repository at this point in the history
When glibc-2.34 started to use clone3() syscall, seccomp policy became
violated and glib2 fork+exec functions failed. This discrepancy was
worked around with passing "--security-opt seccomp=unconfined" option
to a container manager.

Now when Microsoft fixed the policy in ubuntu-22.04 images
(ubuntu-20.04 remains broken) and we moved to ubuntu-22.04, the
workaround is not needed. This patch removes it.

<actions/runner-images#3812>
  • Loading branch information
ppisar committed Mar 28, 2023
1 parent 3d9a471 commit 6f39c11
Showing 1 changed file with 0 additions and 28 deletions.
28 changes: 0 additions & 28 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,6 @@ jobs:
release: ${{ fromJson(needs.get_fedora_releases.outputs.stable) }}
container:
image: quay.io/fedora/fedora:${{ matrix.release }}-x86_64
# Disable seccomp until a container manager in GitHub recognizes
# clone3() syscall,
# <https://github.com/actions/virtual-environments/issues/3812>.
options: --security-opt seccomp=unconfined

steps:
- name: Checkout code
Expand Down Expand Up @@ -78,10 +74,6 @@ jobs:
release: ${{ fromJson(needs.get_fedora_releases.outputs.stable) }}
container:
image: quay.io/fedora/fedora:${{ matrix.release }}-x86_64
# Disable seccomp until a container manager in GitHub recognizes
# clone3() syscall,
# <https://github.com/actions/virtual-environments/issues/3812>.
options: --security-opt seccomp=unconfined

steps:
- name: Install git
Expand Down Expand Up @@ -138,10 +130,6 @@ jobs:
release: ${{ fromJson(needs.get_fedora_releases.outputs.development) }}
container:
image: quay.io/fedora/fedora:${{ matrix.release }}-x86_64
# Disable seccomp until a container manager in GitHub recognizes
# clone3() syscall,
# <https://github.com/actions/virtual-environments/issues/3812>.
options: --security-opt seccomp=unconfined

steps:
- name: Checkout code
Expand Down Expand Up @@ -191,10 +179,6 @@ jobs:
release: ${{ fromJson(needs.get_fedora_releases.outputs.development) }}
container:
image: quay.io/fedora/fedora:${{ matrix.release }}-x86_64
# Disable seccomp until a container manager in GitHub recognizes
# clone3() syscall,
# <https://github.com/actions/virtual-environments/issues/3812>.
options: --security-opt seccomp=unconfined

steps:
- name: Install git
Expand Down Expand Up @@ -247,10 +231,6 @@ jobs:
continue-on-error: true
container:
image: docker.io/library/archlinux:base
# Disable seccomp until a container manager in GitHub recognizes
# clone3() syscall,
# <https://github.com/actions/virtual-environments/issues/3812>.
options: --security-opt seccomp=unconfined

steps:
- name: Install the standard pacman config
Expand Down Expand Up @@ -369,10 +349,6 @@ jobs:
continue-on-error: true
container:
image: registry.opensuse.org/opensuse/tumbleweed
# Disable seccomp until a container manager in GitHub recognizes
# clone3() syscall,
# <https://github.com/actions/virtual-environments/issues/3812>.
options: --security-opt seccomp=unconfined
steps:
- name: Enable docs in container
run:
Expand Down Expand Up @@ -445,10 +421,6 @@ jobs:
continue-on-error: true
container:
image: docker.io/openmandriva/cooker
# Disable seccomp until a container manager in GitHub recognizes
# clone3() syscall,
# <https://github.com/actions/virtual-environments/issues/3812>.
options: --security-opt seccomp=unconfined
outputs:
meson_version: ${{ steps.scanbuild.outputs.available }}
steps:
Expand Down

0 comments on commit 6f39c11

Please sign in to comment.