Updated UI for Pref and Frag to newer androidx #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
o Updated UI for Pref and Frag to newer androidx to remove a big chunk of deprecated warnings.
Required
Nothing. This can be applied without the FTPS pull request in the event that you do not want FTPS merged in.
Fixes
Important notes
Only issue seen: Android 6 and 8 doesn't show the tap animation for the inner screen such as on Advanced Settings. It shows the long press animation but not tap. Android 14 shows the tap so its an issue with the support, compat, or androidx side of things. Really, just a minor issue. Everything else works great. Can workaround this if desired and add some tap animation but may not be identical.
To keep the same, had to wrap all prefs in null checks, as the new stuff doesn't see the rest now when fragment is switched to showing an inner pref screen due to inner pref screen changes in androidx. This is why I didn't want to adjust this to not include the FTPS pull request or adjust the FTPS pull request to this.
Manifest: size & orientation added to fix orientation issues on some sub screens where there was a problem.
iconSpaceReserved use in pref xml to fix the new large indentation spacing issue reserved for icons.
Updated to the current latest versions of all implementation's in build.gradle along with the androidx changes there. Think this fixed a build issue on androidx changes but didn't recheck it. No problems seen on any device so its good to go anyway.
popBackStack() used with theme switch to fix a back press issue that happens after the change without it.
Tests
Fairly well tested all parts of the UI on each test device.
Tested as working on Android 14, 8, 6.
Tested dirty install.
Tested clean install on Android 14, 6.
Full testing of orientation changes to make sure its working properly on all screens, menus, Activities, and Fragments. Includes text editing, settings screens, etc so that user can move away to another app and move back to make adjustments without loss.
Full testing of back button use to make sure its working properly on all screens, menus, Activities, and Fragments.
Tested with two themes to make sure no problems were hidden there.