Get summaries to include optional connectivities #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
force-pushed
the
summary_optional_conns
branch
from
145e25e to
7d1a6a4
Compare
Closed
pp-mo
force-pushed
the
summary_optional_conns
branch
from
7d1a6a4 to
7beaee8
Compare
|
Rebased. |
…-report tests (incomplete).
pp-mo
force-pushed
the
summary_optional_conns
branch
from
7beaee8 to
5bb4399
Compare
Update:In addition to tests for the structure-report, and the major fix for #20, this PR now includes :
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #20
Code building -- simple solution.
But more tests needed, tests are already missing (report summary also)
Wants to go into a 0.1.1 ?
Draft until we resolve some more.