Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acSolverType missing in OLF Specific Parameters #969

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Conversation

caioluke
Copy link
Member

@caioluke caioluke commented Jan 29, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

acSolverType missing from OLF specific parameters list + typo: Newton is written Newtow

@caioluke caioluke requested a review from geofjamg January 29, 2024 12:42
@caioluke
Copy link
Member Author

@geofjamg shouldn't we also add the parameter acSolverType to the list of parameters? Or is there a specific reason for it not to be there?

@geofjamg
Copy link
Member

@geofjamg shouldn't we also add the parameter acSolverType to the list of parameters? Or is there a specific reason for it not to be there?
There is no reason, we just miss it and it should be added indead

Copy link

@jeandemanged jeandemanged self-requested a review January 29, 2024 14:14
Copy link
Member

@jeandemanged jeandemanged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@jeandemanged jeandemanged changed the title Fix typo in acSolverType Fix acSolverType missing in OLF Specific Parameters Jan 29, 2024
@annetill annetill merged commit 0b81797 into main Jan 29, 2024
6 checks passed
@annetill annetill deleted the fix_typo branch January 29, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants