-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally disable voltage regulation of generators with targetP outside Pmin/Pmax #964
Optionally disable voltage regulation of generators with targetP outside Pmin/Pmax #964
Conversation
…LfNetworkParameters Signed-off-by: Caio Luke <[email protected]>
…OLFParameters Signed-off-by: Caio Luke <[email protected]>
Signed-off-by: Caio Luke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renaming & cleanup to do
src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImplTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImplTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New parameter is missing in the specific parameter meta description list
Signed-off-by: Caio Luke <[email protected]>
Signed-off-by: Caio Luke <[email protected]>
Signed-off-by: Caio Luke <[email protected]>
…_to_control_voltage' into enable_generators_outside_limits_to_control_voltage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small minor insignificant remaining tiny issue remaining
src/test/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImplTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: jeandemanged <[email protected]> Signed-off-by: Caio Luke <[email protected]>
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What is the current behavior?
Generator always regulate voltage even if outside Pmin/Pmax limits.
What is the new behavior (if this is a feature change)?
A new parameter in OpenLoadFlowParameters allows to decide if we accept generators with targetP outside active power limits to control voltage, in case active power limits are taken into account via
useActiveLimits
.Does this PR introduce a breaking change or deprecate an API?