Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally disable voltage regulation of generators with targetP outside Pmin/Pmax #964

Merged
merged 11 commits into from
Jan 26, 2024

Conversation

caioluke
Copy link
Member

@caioluke caioluke commented Jan 23, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Feature

What is the current behavior?

Generator always regulate voltage even if outside Pmin/Pmax limits.

What is the new behavior (if this is a feature change)?
A new parameter in OpenLoadFlowParameters allows to decide if we accept generators with targetP outside active power limits to control voltage, in case active power limits are taken into account via useActiveLimits.

Does this PR introduce a breaking change or deprecate an API?

  • No

@caioluke caioluke added the enhancement New feature or request label Jan 23, 2024
@caioluke caioluke self-assigned this Jan 23, 2024
@jeandemanged jeandemanged changed the title Add parameter to enable/disable generators outside limits to control voltage Optionally disable voltage regulation of generators with targetP outside Pmin/Pmax Jan 23, 2024
Copy link
Member

@jeandemanged jeandemanged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renaming & cleanup to do

Copy link
Member

@geofjamg geofjamg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New parameter is missing in the specific parameter meta description list

@caioluke caioluke requested a review from jeandemanged January 25, 2024 13:11
Copy link
Member

@jeandemanged jeandemanged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small minor insignificant remaining tiny issue remaining

Co-authored-by: jeandemanged <[email protected]>
Signed-off-by: Caio Luke <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
98.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@geofjamg geofjamg merged commit 21a673c into main Jan 26, 2024
6 checks passed
@geofjamg geofjamg deleted the enable_generators_outside_limits_to_control_voltage branch January 26, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants