DC security analysis: remove call to sensitivity API #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anne Tilloy <[email protected]>
annetill
commented
Dec 11, 2023
| @@ -238,144 +63,160 @@ private List<OperatorStrategyResult> createOperatorStrategyResults(DcSecurityAna | |||
| LfTopoConfig topoConfig = new LfTopoConfig(); | |||
| findAllSwitchesToOperate(network, actions, topoConfig); | |||
|
|
|||
| // try to find all pst to retain because involved in pst actions | |||
| // try to find all ptc to retain because involved in ptc actions | |||
| findAllPtcToOperate(actions, topoConfig); | |||
There was a problem hiding this comment.
@Hadrien-Godard indeed maybe we have to add RTC to operate if DC security analysis is used as a fall back. I think that actions are not going to be filtered and we can fall in issues.
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
annetill
commented
Jan 5, 2024
| @@ -1887,7 +1876,7 @@ void testDcBusBarSectionContingency() { | |||
| assertEquals(433.012, preContingencyNetworkResult.getBranchResult("L2").getI1(), LoadFlowAssert.DELTA_I); | |||
|
|
|||
| assertEquals(866.025, getPostContingencyResult(result, "BBS1").getNetworkResult().getBranchResult("L2").getI1(), LoadFlowAssert.DELTA_I); | |||
| assertEquals(Double.NaN, getPostContingencyResult(result, "BBS1").getNetworkResult().getBranchResult("L1").getI1(), LoadFlowAssert.DELTA_I); | |||
| // assertEquals(Double.NaN, getPostContingencyResult(result, "BBS1").getNetworkResult().getBranchResult("L1").getI1(), LoadFlowAssert.DELTA_I); | |||
There was a problem hiding this comment.
Now, DC is conformed to AC computation: no branch result for a disabled line at both side. So the line test has to be removed.
Signed-off-by: Anne Tilloy <[email protected]>
annetill
commented
Jan 5, 2024
| @@ -2350,12 +2338,12 @@ void testAcceptableDurations() { | |||
| SecurityAnalysisResult result2 = runSecurityAnalysis(network, contingencies.getContingencies(network), Collections.emptyList(), securityAnalysisParameters); | |||
|
|
|||
| LimitViolation violation4 = new LimitViolation("NHV1_NHV2_2", null, LimitViolationType.CURRENT, "permanent", | |||
| 2147483647, 900.0, 1.0F, 911.605688194146412890625, TwoSides.ONE); | |||
| 2147483647, 899.9999999999999, 1.0F, 911.6056881941461, TwoSides.ONE); | |||
There was a problem hiding this comment.
899.99999999 is weird...
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Hadrien-Godard
approved these changes
Jan 8, 2024
geofjamg
approved these changes
Jan 8, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Yes. Issues are:
What kind of change does this PR introduce?
A big code sharing with AC security analysis, but:
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information:
iin final state!