Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release CI #184

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix release CI #184

merged 1 commit into from
Nov 8, 2024

Conversation

rolnico
Copy link
Member

@rolnico rolnico commented Nov 7, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
Ci ran only on release creation, which does not work when writing a draft and then releasing

What is the new behavior (if this is a feature change)?
CI run on release publishing

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Nicolas Rol <[email protected]>
@rolnico rolnico requested a review from jeandemanged November 7, 2024 16:25
Copy link

sonarqubecloud bot commented Nov 7, 2024

Copy link

sonarqubecloud bot commented Nov 7, 2024

Copy link
Member

@jeandemanged jeandemanged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahem, sorry for this ...
thank you !

@rolnico rolnico merged commit 0692275 into main Nov 8, 2024
13 checks passed
@rolnico rolnico deleted the nro/fix_release_ci branch November 8, 2024 07:53
rolnico added a commit that referenced this pull request Nov 8, 2024
Signed-off-by: Nicolas Rol <[email protected]>
(cherry picked from commit 0692275)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants