Add Windows CI #176
Merged
Add Windows CI #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeandemanged
commented
Oct 9, 2024
| configure_file(${file} ${file} NEWLINE_STYLE LF) # required for windows ctest | ||
| execute_process( COMMAND ${CMAKE_COMMAND} -E compare_files ${file} ${expected_file} | ||
| execute_process( COMMAND ${CMAKE_COMMAND} -E compare_files --ignore-eol ${file} ${expected_file} |
There was a problem hiding this comment.
changed this way because previous code was assuming code was checked out using LF end of files, but this is not the default git behavior on Windows.
Note that --ignore-eol requires cmake 3.14+
| @@ -28,12 +28,14 @@ set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake") | |||
| set(INSTALL_CMAKE_DIR cmake CACHE PATH "Installation directory for cmake files") | |||
|
|
|||
| if(MSVC) | |||
| add_compile_definitions(WIN32) | |||
| add_definitions(-D_WIN32_WINNT=0x0A00) | |||
| cmake_minimum_required(VERSION 3.12 FATAL_ERROR) | ||
| cmake_minimum_required(VERSION 3.14 FATAL_ERROR) |
There was a problem hiding this comment.
For --ignore-eol option in tests, see metrix-simulator/cmake/tnr.cmake
| metrix_test("variantes_regroupees_complexe" 11) # no check here because of random and equivalent solutions | ||
| metrix_test_no_check("variantes_regroupees_complexe" 11) # no check here because of random and equivalent solutions |
There was a problem hiding this comment.
Note that the comment saying no check here because of random and equivalent solutions was already there...
On windows the results differ only in lines ordering.
There was a problem hiding this comment.
well actually also happens on Ubuntu, but sporadically: https://github.com/powsybl/powsybl-metrix/actions/runs/11273050987/job/31349239541
There was a problem hiding this comment.
I am not really a cmake expert ... feedback welcome
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
jeandemanged
force-pushed
the
windows-ci
branch
from
6b6fea9 to
bc9a44c
Compare
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
# Conflicts: # .github/workflows/release-ci.yml
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
# Conflicts: # .github/old_workflows/ci_centos7.yml # .github/old_workflows/ci_ol8.yml # .github/old_workflows/ci_ubuntu.yml # .github/old_workflows/maven.yml # .github/old_workflows/qa_pr_cpp_centos7.yml # .github/old_workflows/qa_pr_cpp_ol8.yml # .github/old_workflows/qa_pr_cpp_ubuntu.yml # .github/workflows/dev-ci.yml # .github/workflows/full-ci.yml # .github/workflows/release-ci.yml
|
|
rolnico
pushed a commit
that referenced
this pull request
Nov 7, 2024
* try rework github workflows Signed-off-by: Damien Jeandemange <[email protected]> * try rework github workflows Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * clang tidy Signed-off-by: Damien Jeandemange <[email protected]> * artifacts Signed-off-by: Damien Jeandemange <[email protected]> * artifacts Signed-off-by: Damien Jeandemange <[email protected]> * artifacts Signed-off-by: Damien Jeandemange <[email protected]> * artifacts Signed-off-by: Damien Jeandemange <[email protected]> * wip Signed-off-by: Damien Jeandemange <[email protected]> * fix Signed-off-by: Damien Jeandemange <[email protected]> * wip windows ci Signed-off-by: Damien Jeandemange <[email protected]> * wip windows ci Signed-off-by: Damien Jeandemange <[email protected]> * wip windows ci Signed-off-by: Damien Jeandemange <[email protected]> * wip windows ci / cpp tests Signed-off-by: Damien Jeandemange <[email protected]> * test Signed-off-by: Damien Jeandemange <[email protected]> * test Signed-off-by: Damien Jeandemange <[email protected]> * test Signed-off-by: Damien Jeandemange <[email protected]> * wip Signed-off-by: Damien Jeandemange <[email protected]> * fix Signed-off-by: Damien Jeandemange <[email protected]> * fix Signed-off-by: Damien Jeandemange <[email protected]> * fix Signed-off-by: Damien Jeandemange <[email protected]> * use softprops/action-gh-release Signed-off-by: Damien Jeandemange <[email protected]> * use softprops/action-gh-release Signed-off-by: Damien Jeandemange <[email protected]> * update readme for cmake 3.14 Signed-off-by: Damien Jeandemange <[email protected]> --------- Signed-off-by: Damien Jeandemange <[email protected]> Co-authored-by: Nicolas Rol <[email protected]> (cherry picked from commit 3c3943a)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
No windows CI
What is the new behavior (if this is a feature change)?
Add windows CI, including publishing of windows binaries on release
Does this PR introduce a breaking change or deprecate an API?