Use scontrol instead of sacct to get status of finished tasks. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yichen88
force-pushed
the
remove-sacct-usage
branch
from
59f29a5 to
47232b6
Compare
The sacct command would failed when slurm DB is not accessible for some reason, and then the whole slurm computation manager could not continue to work. From this slurm schema image(https://slurm.schedmd.com/arch.gif), the scontrol command is not depends on slurm DB. Signed-off-by: yichen88 <[email protected]>
yichen88
force-pushed
the
remove-sacct-usage
branch
from
47232b6 to
94c018c
Compare
Signed-off-by: yichen88 <[email protected]>
yichen88
force-pushed
the
remove-sacct-usage
branch
from
b22804f to
aa9b5d5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
sylvlecl
reviewed
Oct 21, 2020
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sacct command would failed when slurm DB is not accessible for some reason, and then the whole slurm computation manager could not continue to work.
From this slurm schema image(https://slurm.schedmd.com/arch.gif), the scontrol command is not depends on slurm DB.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the rest#51
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)