Remove generics from ContingenciesProviderFactory interface. #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic return type does not seem to bring anything really useful, while on the other side it prevents (or makes clumsy) the use of most fluent APIS which rely on a known return type (streams, optionals ...). It also causes "unchecked" warnings in implementations. It seems very unlikely that this change actually breaks some client code. Signed-off-by: Sylvain Leclerc <[email protected]>
geofjamg
approved these changes
May 2, 2019
See the analysis in the PR text: in my opinion it's very unlikely to break any client-code. |
frannicot
pushed a commit
that referenced
this pull request
May 27, 2019
The generic return type does not seem to bring anything really useful, while on the other side it prevents (or makes clumsy) the use of most fluent APIS which rely on a known return type (streams, optionals ...). It also causes "unchecked" warnings in implementations. It seems very unlikely that this change actually breaks some client code. Signed-off-by: Sylvain Leclerc <[email protected]> Signed-off-by: frannicot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
API fix.
What is the current behavior? (You can also link to an open issue here)
The generic return type in
ContingenciesProviderFactorydoes not seem to bring anything really useful,while on the other side it prevents (or makes clumsy) the use of most
fluent APIS which rely on a known return type (streams, optionals ...).
It also causes "unchecked" warnings in implementations.
It seems very unlikely that this change actually breaks some client code.
What is the new behavior (if this is a feature change)?
The factory returns a plain
ContingencyProvider.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
It seems very unlikely that this change actually breaks some client code.
I think it could only happen if the generic type is explicit in the method call:
Not sure when one would need to use this.