Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contingencies to limit violation detector API. #772

Merged
merged 3 commits into from
Apr 29, 2019

Conversation

sylvlecl
Copy link
Contributor

@sylvlecl sylvlecl commented Apr 25, 2019

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Some documentation and a non-breaking evolution in the API of limit violations detectors.

What is the current behavior? (You can also link to an open issue here)

Limit violation detectors cannot take into account the context in which they operate (on N situation? after a contingency?).

What is the new behavior (if this is a feature change)?

Limit violation detectors may now adapt their behaviour to the specified contingency.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No, a default behaviour is provided for new methods.

@sylvlecl sylvlecl changed the title Add contingencies to limit violation detector API. [WIP] Add contingencies to limit violation detector API. Apr 25, 2019
@coveralls
Copy link

coveralls commented Apr 25, 2019

Coverage Status

Coverage increased (+0.03%) to 81.132% when pulling 1e20db0 on limit-violations-improvements into f8be1d2 on master.

@sylvlecl sylvlecl force-pushed the limit-violations-improvements branch 2 times, most recently from a1d8845 to 475a0f8 Compare April 25, 2019 14:40
Limit violation detectors can now adapt their behaviour to the current contingency.
Security analyses should now call the corresponding methods.
At the same time, some javadoc is added for for LimitViolation class,
and some utilities for limit violations in general

Signed-off-by: Sylvain Leclerc <[email protected]>
@sylvlecl sylvlecl force-pushed the limit-violations-improvements branch from 475a0f8 to b1bd95e Compare April 25, 2019 15:11
@sylvlecl sylvlecl changed the title [WIP] Add contingencies to limit violation detector API. Add contingencies to limit violation detector API. Apr 25, 2019
@sylvlecl sylvlecl requested a review from mathbagu April 25, 2019 15:15
@mathbagu mathbagu requested review from miovd and removed request for mathbagu April 25, 2019 15:39
@miovd miovd merged commit 13ef4d4 into master Apr 29, 2019
@miovd miovd deleted the limit-violations-improvements branch April 29, 2019 12:39
frannicot pushed a commit that referenced this pull request May 27, 2019
* Add Contingency information to limit violation detector API.

Limit violation detectors can now adapt their behaviour to the current contingency.
Security analyses should now call the corresponding methods.
At the same time, some javadoc is added for for LimitViolation class,
and some utilities for limit violations in general

* Restore moved classes to ensure smooth transition.

Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: frannicot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants