Put back Cassandra implementation #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
rolnico
force-pushed
the
nro/cassandra_is_back
branch
from
a2eaf22 to
a0c9616
Compare
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
EtienneLt
reviewed
Oct 21, 2024
afs-cassandra/src/main/java/com/powsybl/afs/cassandra/CassandraAppFileSystemConfig.java
Outdated
Show resolved
Hide resolved
afs-cassandra/src/main/java/com/powsybl/afs/cassandra/CassandraAfsException.java
Show resolved
Hide resolved
afs-cassandra/src/main/java/com/powsybl/afs/cassandra/CassandraAppFileSystemProvider.java
Show resolved
Hide resolved
afs-cassandra/src/main/java/com/powsybl/afs/cassandra/CassandraAppStorage.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private void executeStatements(List<SimpleStatement> statements) { | ||
| for (SimpleStatement statement : statements) { |
There was a problem hiding this comment.
I dont know but should it be better if it was a batch ?
afs-cassandra/src/main/java/com/powsybl/afs/cassandra/CassandraAppStorage.java
Outdated
Show resolved
Hide resolved
| private CassandraUtil() { | ||
| } | ||
|
|
||
| public static void print(CassandraContext context, PrintStream out) { |
There was a problem hiding this comment.
well these method add print, I dont know if it is usefull but a Logger would be better
There was a problem hiding this comment.
I'm not even sure these methods are used, I'll have to check later
EtienneLt
approved these changes
Oct 21, 2024
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
No Cassandra implementation
What is the new behavior (if this is a feature change)?
Cassandra implementation is back and available with Java 17
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: