Do not connect backward dependencies to listener when invalidate #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoRte
force-pushed
the
BGO/projectnode_listener_optimisation
branch
from
cf22fcb to
592b4b3
Compare
added 2 commits
April 24, 2024 16:08
Signed-off-by: GONCALVES Bruno <[email protected]>
Signed-off-by: GONCALVES Bruno <[email protected]>
BrunoRte
force-pushed
the
BGO/projectnode_listener_optimisation
branch
from
592b4b3 to
595bbed
Compare
Signed-off-by: GONCALVES Bruno <[email protected]>
|
rolnico
requested changes
Jun 5, 2024
afs-core/src/test/java/com/powsybl/afs/DependencyCacheTest.java
Outdated
Show resolved
Hide resolved
added 3 commits
June 11, 2024 10:54
Signed-off-by: GONCALVES Bruno <[email protected]>
Signed-off-by: GONCALVES Bruno <[email protected]>
…eckstyle Signed-off-by: GONCALVES Bruno <[email protected]>
BrunoRte
force-pushed
the
BGO/projectnode_listener_optimisation
branch
from
1004956 to
60cfb83
Compare
Signed-off-by: Nicolas Rol <[email protected]>
rolnico
approved these changes
Jun 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
NO
What kind of change does this PR introduce?
Feature
What is the current behavior?
When object is invalidated, it's invalidate all this backward dependencies.
To do this we create a new object in order to invalidate it.
It is not necessary to "connect" it because this has to effect of subscribing it to event listener which is useless since its lifespan is only local to the function
What is the new behavior (if this is a feature change)?
The created backward dependency is no longer connected upon invalidation
Does this PR introduce a breaking change or deprecate an API?
What changes might users need to make in their application due to this PR? (migration steps)
The invalidate() method now return the list of all the backwardDependencies.
All classes that override this method must update their signature as well as their behavior