Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export to Guitar Pro format #350

Closed
cameronwhite opened this issue Dec 29, 2021 · 3 comments
Closed

Export to Guitar Pro format #350

cameronwhite opened this issue Dec 29, 2021 · 3 comments
Labels
C-guitarpro enhancement
Milestone
Alpha 18

Comments

@cameronwhite
Copy link
Member

This would be useful for exporting to other applications, websites etc which may not understand .pt2 files.

The best approach is probably to create .gp (GP7) files, since this mirrors how the guitar pro importer works. (The importers for versions 3/4/5/6 parse the file and then convert to our internal representation of the GP7 data, which is then converted to a .pt2 Score)
@Ebdim9th
Copy link

Ebdim9th commented Jan 9, 2022 •
edited
Loading

Does ascii export relate to this coding wise or is that an entirely different job even though technically an export? Creating a .txt file and..?

@cameronwhite
Copy link
Member Author

Ascii export is fairly unrelated since it's exporting to a very different format

@Ebdim9th
Copy link

Ebdim9th commented Jan 13, 2022 •
edited
Loading

So for now its a one or the other proposition and exporting to GP would be more useful as the GP file you end up w can export to ascii, though i do hope to see import/export of ascii too eventually

@cameronwhite cameronwhite added this to the Beta milestone Jan 27, 2022
cameronwhite added a commit that referenced this issue Feb 8, 2022
@cameronwhite
Initial boilerplate to register the GP7 exporter
43315ae 
#350
cameronwhite added a commit that referenced this issue Feb 8, 2022
@cameronwhite
Initial work on creating .gp files
19e645b 
Currently this creates the zip contents, with the version entry and an empty score.gpif xml file

Refactored the Gp7::Document header a bit so that the code for converting to XML can belong in a separate file.

#350
cameronwhite added a commit that referenced this issue Feb 8, 2022
@cameronwhite
Convert score info to the .gp format
4765b6b 
The .gp files can now successfully load in Guitar Pro!

#350
cameronwhite added a commit that referenced this issue Feb 20, 2022
@cameronwhite
Export chord names / diagrams to .gp files
44e1fcc 
- Add enum <-> string conversions for the Note::Accidental enum
- Fixed a couple issues with roundtripping chord diagrams that caused different results to be produced. On import, identical diagrams from different tracks are consolidated, and we avoid inserting duplicate chord text items at the same position

Bug: #350
@cameronwhite cameronwhite modified the milestones: Beta, Alpha 18 Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-guitarpro enhancement
Projects
None yet
Milestone
Alpha 18
Development

No branches or pull requests
2 participants
@cameronwhite @Ebdim9th