Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More robust reading of .pt2 files #294

Closed
2 tasks
cameronwhite opened this issue Jun 7, 2020 · 0 comments
Closed
2 tasks

More robust reading of .pt2 files #294

cameronwhite opened this issue Jun 7, 2020 · 0 comments
Assignees
@cameronwhite
Labels
enhancement
Milestone
Alpha 12

Comments

@cameronwhite
Copy link
Member

Currently, reading of .pt2 files makes assumptions about the order of keys in the JSON objects, which is a main reason why it refuses to open older file versions.

The attached file (reordered.zip) was generated by loading the JSON data into Python and saving it out with sort_keys set to `True.

TODO:

  • Allow fields to be read in any order
  • Relax requirements on reading newer file versions. They should be able to ignore any new data and just read the data they expect.
@cameronwhite cameronwhite self-assigned this Jun 7, 2020
cameronwhite added a commit that referenced this issue Jun 7, 2020
@cameronwhite
Make the .pt2 importer more robust against reordered keys.
ba2aaca 
Instead of iterating in-order over the JSON document, look up the keys that we expect to see. This avoids relying on the ordering of the keys, which is not guaranteed to be in any particular order.

#294
@cameronwhite cameronwhite added this to the Alpha 12 milestone Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cameronwhite cameronwhite

Labels
enhancement
Projects
None yet
Milestone
Alpha 12
Development

No branches or pull requests
1 participant
@cameronwhite