Mixer does not seem functioning for panning/volume for each player

[jairus-crabb]

Like title says, I have two players on different instruments and panning/volume changes seem to do nothing. I can't find anywhere else where this can be changed.

[jairus-crabb]

I also know a bit of C++, if this is a bug, I'd be happy to look into the issue myself if no one else knows what may be wrong of the top of their heads.

[cameronwhite]

Yeah I think this is a bug - there was a big refactor of how the midi playback was implemented, so I think this functionality was lost then. Patches are welcome!
Ultimately I think you need to end up calling device.setChannelMaxVolume() in the midi player. You might want to also fix MidiFile to properly record the source player / instrument for use in the midi player - there is some partial code already for that.

[mostafa-nabil]

I had a look at the issue and I did a quick fix for it locally. Hopefully I will deliver something soon.
My fix was mainly in MidiFile.cpp, but so far I did not need to use device.setChannelMaxVolume(). Still I will need more testing to do this
edit: should the volume change online while the music is playing? or it is sufficient to make the volume be updated after pausing and playing again?

[cameronwhite]

Yeah, I think the original intention was to have volume changes take effect while playback is active (similar to changing playback speed or enabling / disabling the metronome)

[Ebdim9th]

Before the refactoring? the mixer was working on Alpha 8....

[cameronwhite]

This was fixed with #303

[Ebdim9th]

Do I do like before and download and install an updated version of Alpha 13 for this feature?

[cameronwhite]

Yeah, the installers from https://github.com/powertab/powertabeditor/actions/runs/376872326 will have the fix

[Ebdim9th]

thanks!

[Ebdim9th]

huh. installed, didnt make any difference. headscratch

[cameronwhite]

Hmm, adjusting the volume during playback works fine for me with those installers (tested on macOS)

…

On Mon, Nov 23, 2020 at 10:41 AM Ebdim9th ***@***.***> wrote: huh. installed, didnt make any difference. *headscratch* — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#276 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACKGT2D7IHFQBZLA6VGD73SRJ7BTANCNFSM4KACWHBQ> .

[Ebdim9th]

any ideas on what might be wrong with mine? Should i try to re-install? Hmmm I'll try that first....

[Ebdim9th]

The 'repair' relaunch worked perfectly! I didn't even have to temporarily shut down down Avast.... it balked a little but not enough to stop the re-install from completing.....

[Ebdim9th]

I got a new Dell w Windows 10, installed, I get that nifty dark theme choice but the volume pan "knobs" aren't working....

[cameronwhite]

Is the volume not working, the pan, or both? Offhand I'm not sure if the pan will update live during playback

…

On Sat., Feb. 13, 2021, 1:46 a.m. Ebdim9th, ***@***.***> wrote: I got a new Dell w Windows 10, installed, I get that nifty dark theme choice but the volume pan "knobs" aren't working.... — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#276 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACKGT67TNULMRJGWOM4SR3S6YN2TANCNFSM4KACWHBQ> .

[Ebdim9th]

only the pan, the volume sliders work perfectly, i would test by panning hard left and right then dropping the volume of first one guitar then another to zero ...

[cameronwhite]

Yeah, I tested now and the pan seems to be ignored .. The volume slider works fine
Reopening this issue.

[Ebdim9th]

Thanks man! I really appreciate it... seriously. This is the /only/ tab program where i can go and not only be heard but find my requests pretty promptly and successfully implemented.