Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make editing behaviour more consistent #23

Closed
cameronwhite opened this issue Jul 24, 2014 · 2 comments
Closed

Make editing behaviour more consistent #23

cameronwhite opened this issue Jul 24, 2014 · 2 comments
Labels
bug C-editing C-ui medium priority
Milestone
Alpha 15

Comments

@cameronwhite
Copy link
Member

  • For a barline, Shift+B will edit the barline type, and Ctrl+Del deletes it
  • For a player change, I can't edit an existing one and have to remove and recreate it just to add a new player - this gets really annoying!
    • Similar for tempo markers, directions, etc
    • For things like natural harmonics or trills, this behavior is probably okay though
@Canaanabolaanan
Copy link

i deleted every barline
Ctrl+Del to delete notes across a measure on one staff will delete the contained barlines which affect related staffs in a system, for example.

@cameronwhite
Copy link
Member Author

Also, clicking to edit things is somewhat inconsistent. You can click to edit clefs and time signatures, but can only click a key signature if it's not C major, and you can't click tempo markers. The clickable region for barlines at the start of a system also varies depending on whether you have a regular barline, a repeat start, etc.

image

@cameronwhite cameronwhite mentioned this issue Sep 6, 2014
Closed
@cameronwhite cameronwhite mentioned this issue Sep 22, 2014
Closed
@cameronwhite cameronwhite added this to the Alpha 7 milestone Jan 25, 2015
@cameronwhite cameronwhite modified the milestones: Alpha 8, Alpha 7 Apr 25, 2015
@cameronwhite cameronwhite removed this from the Alpha 8 milestone Jun 28, 2015
@cameronwhite cameronwhite added this to the Alpha 15 milestone Jan 10, 2021
cameronwhite added a commit that referenced this issue Jan 10, 2021
@cameronwhite
Improve the workflow for editing tempo markers.
56e5ba8 
- Tempo markers can now be selected by clicking on them.
- While selected, delete can be pressed to remove the tempo marker.
- Double clicking will open the dialog to edit the existing tempo marker, rather than having to delete and re-create it.

Bug: #23, #192, #220
cameronwhite added a commit that referenced this issue Jan 11, 2021
@cameronwhite
Support the new editing style for rehearsal signs.
ec1006e 
This is similar to the changes in 56e5ba8 for tempo markers.

- Missing switch cases are now compiler errors to flag this issue more easily when adding new enums.
- Fixed a bug where using the menu item / keyboard shortcut to add a new item actually enabled the "remove" flag, since Qt forwards the "checked" argument to the slot. An explicit lambda is now used.
- Clear the selection after editing an item.

Bug: #23, #192, #220
cameronwhite added a commit that referenced this issue Jan 16, 2021
@cameronwhite
Support the new editing style for player changes.
29328bd 
This is similar to the changes in 56e5ba8 for tempo markers.

Bug: #23, #192, #220
cameronwhite added a commit that referenced this issue Jan 16, 2021
@cameronwhite
Implement the new editing style for volume swells.
d6aadf2 
This is similar to the changes in 56e5ba8 for tempo markers.

Bug: #23, #192, #220
cameronwhite added a commit that referenced this issue Jan 16, 2021
@cameronwhite
Allow clicking on the score info to open the file info dialog for edi…
9b324f9 
…ting.

Also fixed an issue I noticed where the mouse cursor could reset itself due to multiple "hover enter" events being fired before any hover leave events occurred.

Bug: #23, #192, #220
cameronwhite added a commit that referenced this issue Jan 17, 2021
@cameronwhite
Implement the new editing style for repeat endings.
78013d9 
This is similar to the changes in 56e5ba8 for tempo markers.

Bug: #23, #192, #220
cameronwhite added a commit that referenced this issue Jan 17, 2021
@cameronwhite
Implement the new editing style for alterations of pace.
1dd0cfa 
This is similar to the changes in 56e5ba8 for tempo markers.

Bug: #23, #192, #220
cameronwhite added a commit that referenced this issue Jan 17, 2021
@cameronwhite
Implement the new editing style for dynamics.
97b66d3 
This is similar to the changes in 56e5ba8 for tempo markers.

Bug: #23, #192, #220
cameronwhite added a commit that referenced this issue Jan 23, 2021
@cameronwhite
Implement the new editing style for multi-bar rests.
51a8735 
This is similar to the changes in 56e5ba8 for tempo markers.

Bug: #23, #192, #220
cameronwhite added a commit that referenced this issue Jan 24, 2021
@cameronwhite
Implement the new editing style for chord names.
dda6bdb 
This is similar to the changes in 56e5ba8 for tempo markers.

Bug: #23, #192, #220
cameronwhite added a commit that referenced this issue Apr 17, 2021
@cameronwhite
Implement the new editing style for musical directions.
f6a092b 
This is similar to the changes in 56e5ba8 for tempo markers.

Bug: #23, #192, #220
cameronwhite added a commit that referenced this issue Apr 17, 2021
@cameronwhite
Implement the new editing style for bends.
32f639e 
This is similar to the changes in 56e5ba8 for tempo markers.

Bug: #23, #192, #220
cameronwhite added a commit that referenced this issue May 23, 2021
@cameronwhite
Make interaction and drawing of barlines consistent with other clicka…
3a34992 
…ble items.

Bug: #23, #192, #220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug C-editing C-ui medium priority
Projects
None yet
Milestone
Alpha 15
Development

No branches or pull requests
2 participants
@cameronwhite @Canaanabolaanan