Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback is too slow #214

Closed
Malethar opened this issue Mar 3, 2016 · 13 comments
Closed

Playback is too slow #214

Malethar opened this issue Mar 3, 2016 · 13 comments
Labels
Milestone

Comments

@Malethar
Copy link

Malethar commented Mar 3, 2016

The playback of tabs way too slow. If you export the midi or use any other tab playback software, you'll notice that it's played way faster than in PTE.

@cameronwhite
Copy link
Member

Do you have a specific tab that has this problem? It seems okay for me (on OSX) - I timed using a stopwatch how long it took to play a few bars in PTE vs Guitar Pro, and the difference was negligible.

@Malethar
Copy link
Author

Malethar commented Mar 5, 2016

on Windows 10, it's 20 bpm slower

On Sat, Mar 5, 2016 at 4:23 PM, Cameron White [email protected]
wrote:

Do you have a specific tab that has this problem? It seems okay for me (on
OSX) - I timed using a stopwatch how long it took to play a few bars in PTE
vs Guitar Pro, and the difference was negligible.


Reply to this email directly or view it on GitHub
#214 (comment)
.

@cameronwhite
Copy link
Member

OK, I'll give it a try on my Windows machine later

@Canaanabolaanan
Copy link

I can confirm it's slower. I suspect the BPM differential may be a percentage rather than an absolute number like 20 though.

@Malethar
Copy link
Author

Malethar commented Mar 6, 2016

yeah, i just used 20 as a way to compensate for the time being

On Sat, Mar 5, 2016 at 10:37 PM, Canaanabolaanan [email protected]
wrote:

I can confirm it's slower. I suspect the BPM differential may be a
percentage rather than an absolute number like 20 though.


Reply to this email directly or view it on GitHub
#214 (comment)
.

@nikita-kiryanov
Copy link

I can also report that playback is noticeably slow, and it's like this in all tabs I tried so far. By rough estimation, it's about 25% slower than it should be, and I also noticed that sometimes it suddenly picks up speed, and then slows down again I'm using Windows 10.

@cameronwhite
Copy link
Member

Can you try with the latest release? I suspect #269 might have fixed this.

@acjay
Copy link

acjay commented Jun 9, 2020

I think there are still playback issues with slides, specifically. Things seem fine for bends, but slides cause the tempo to slow down for the duration of the slide. I'm experiencing this on Windows 10.

@cameronwhite
Copy link
Member

Thanks, I think I can reproduce that on OSX. It seems to be more an issue with slides in/out of a note rather than shift/legato slides between notes - does that match what you were seeing?

@acjay
Copy link

acjay commented Jun 9, 2020

I think it's affecting all slides, as far as I can tell

@cameronwhite
Copy link
Member

Yeah, testing on Windows I'm seeing that a bit more, although performance is a bit harder to evaluate on a VM

@cameronwhite
Copy link
Member

Attached is a simple file that I was testing with:
slides.zip

cameronwhite added a commit that referenced this issue Jun 9, 2020
This occurred if the event didn't record a system location, which is the case for pitch wheel events.
This seems to improve the tempo drift with slides, but needs more testing on other platforms

#214
cameronwhite added a commit that referenced this issue Jun 10, 2020
@cameronwhite
Copy link
Member

I think this should be fixed with 6604fb5 - I've verified that the wall clock time between notes in that file stays consistently at 500ms (120bpm) now, whereas before it was often drifting up to 540-550ms with some of the slides.

Thanks for all the testing on this!

@cameronwhite cameronwhite added this to the Alpha 12 milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants