Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player Change adds Player without making a choice #147

Closed
henkmosseveld opened this issue Sep 21, 2014 · 2 comments
Closed

Player Change adds Player without making a choice #147

henkmosseveld opened this issue Sep 21, 2014 · 2 comments

Comments

@henkmosseveld
Copy link

I made a new file
changed the player to a three-string instrument
added a new system
entered the caret in the new system
tried to add a new Player with Player Change
There is no choice (except none) to be made in the pop-up menu
So I enter OK without making a selection, (not even none, just the blank field):

player can be added without making a selection

PTE still enters a Player 1

@Canaanabolaanan
Copy link

If you do this process, it no longer adds Player 1 to the measure. But it does consider a player change to have occurred. You can click the "Player" menu and the Player Change will be checked despite nothing displaying in the measure. Maybe the "Ok" option should be disabled until a proper player for the measure is selected. Otherwise, just "cancel" should be accessible.

@cameronwhite
Copy link
Member

IMO it should be valid to have an empty player change, since to fix #146 we'll need to clear the active players which have the wrong number of strings. I think we maybe just need to have a visual indication that there are no active players, instead of having the player change be invisible.

@cameronwhite cameronwhite reopened this Dec 29, 2014
@cameronwhite cameronwhite modified the milestones: Alpha 6, Alpha 5 Dec 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants