Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Staging deployment to sidestream cluster #56

Merged
merged 5 commits into from
Jun 28, 2023

Conversation

DeusAvalon
Copy link
Contributor

@DeusAvalon DeusAvalon commented Jun 21, 2023

Adds the workflow to deploy into the sidestream kubernetes cluster via ArgoCD.

Workflow got fully tested here

Deployment Value Files can be found in the sidestream-tech/k8s-projects repo

New URL is:
https://powerhouse.switchboard.k8s.sidestream.tech

@DeusAvalon DeusAvalon requested a review from valiafetisov June 21, 2023 11:46
@@ -0,0 +1,2 @@
# All the files under /.github/workflows belong to the sidestream team members to prevent malicious changes to the pipeline
/.github/workflows/ @DeusAvalon @valiafetisov @BracketJohn
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valiafetisov @BracketJohn I would have loved to use our @powerhouse-inc/Sidestream team but because the GitHub Team is a set to secret it cannot be used in a CO file.

See the other CO file in the k8s-projects repo:
https://github.com/sidestream-tech/k8s-projects/blob/main/CODEOWNERS

And i removed the SyncPolicy for the deployment to prevent auto deployments:
https://github.com/sidestream-tech/k8s-projects/commit/e3f60a612df830732fd480187480fe362aecbad1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think it's enough for this PR

@valiafetisov
Copy link
Contributor

Question: the other open PR #55 introduces new API_ORIGIN env variable for the api service that have to be set in staging/production (to the url at which the service is running, e.g. https://powerhouse.switchboard.k8s.sidestream.tech).
Do I need to now open another PR to the sidestream-tech/k8s-projects repo in order to set it before merging #55?

@DeusAvalon
Copy link
Contributor Author

DeusAvalon commented Jun 28, 2023

Yes exactly! :) Yes as we also disabled AutoSync for this Application we can just merge both PR's and then manual sync the application in Argo to deploy all the changes at once!

@valiafetisov valiafetisov merged commit 77cd773 into main Jun 28, 2023
@valiafetisov valiafetisov deleted the add-staging-deployment branch June 28, 2023 10:40
@valiafetisov
Copy link
Contributor

@valiafetisov
Copy link
Contributor

valiafetisov commented Jun 28, 2023

Also, since you have admin rights in this repo, can you please

  • Add requirement (that seems to be lost when the repo was moved) to have at least one approval before merging
  • Protect main branch (if it's not yet done)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants