Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add logging #21
Feat: add logging #21
Changes from 2 commits
fe0187d
cc3845a
561445e
1fabb55
0277a0b
af86c86
118c055
d49b8bd
1b63827
9d0442e
856ed6f
9a4fe25
367532e
12ca9d6
8bc37ee
deeb411
0b97e87
df042dc
d41337b
3d484ec
e0a0352
690bd91
9c40e07
d33fb4a
3aa9dae
157f413
5c6a3ca
e2daa00
48c3264
2562aad
e2d8fc0
4e205e7
4caa41c
e9fc986
76e73ed
6cee018
58850a4
47d6fdd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this the reason why main was broken? Can you please be vocal about it? If you're fixing it in this PR (instead of opening a dedicated one) can you please add a build step to the CI to prevent this from happening in the future? 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not notice that it was broken, what was the error / did not work?
i've ran it before writing this, seems to work on my machine
at least not via this file since it's not listed in the PR's diff.
what are we building exactly? i'm only familiar with builds of webapps where we want to be able to serve statically as a result of the command. But this here is an api.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Via verbal discussion:
Reason for the message to appear at the first place:
startServer
started to return a value (server) instead of spawning server and returning void (this change was needed for the test context init) which resulted into triggeringthen
immediately.This file was deleted.