Skip to content

Commit

Permalink
Update rubocop version (#283)
Browse files Browse the repository at this point in the history 
We have not updated our rubocop version in a while. Let's bring in all
the security patches, updates, and bugfixes that we can.

Note that we also had to add appraisal to cygnet and rubocop-cobra to
avoid dependency issues between ruby and rails versions.
  • Loading branch information
@that-jill
that-jill authored Oct 2, 2024
1 parent 3cb7106 commit d60d935
Show file tree
Hide file tree
Showing 72 changed files with 2,195 additions and 540 deletions.
1 change: 1 addition & 0 deletions .github/workflows/cygnet.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,6 @@ jobs:
with:
package: ${{ github.workflow }}
workdir: "packages/${{ github.workflow }}"
gemfiles: "['gemfiles/rails_6_0.gemfile','gemfiles/rails_6_1.gemfile','gemfiles/rails_7_0.gemfile']"
ruby: '["3.0","3.1","3.2","3.3"]'
secrets: inherit
1 change: 1 addition & 0 deletions .github/workflows/rubocop-cobra.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ jobs:
package: ${{ github.workflow }}
workdir: "packages/${{ github.workflow }}"
ruby: '["3.0","3.1","3.2","3.3"]'
gemfiles: "['gemfiles/rails_6_0.gemfile','gemfiles/rails_6_1.gemfile','gemfiles/rails_7_0.gemfile']"
secrets: inherit
17 changes: 9 additions & 8 deletions packages/audit_tracker/Gemfile.lock
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
PATH
remote: ../rubocop-powerhome
specs:
rubocop-powerhome (0.5.2)
rubocop (~> 1.52.0)
rubocop-powerhome (0.5.3)
rubocop (= 1.66.1)
rubocop-performance
rubocop-rails
rubocop-rake
Expand Down Expand Up @@ -58,6 +58,7 @@ GEM
i18n (1.14.5)
concurrent-ruby (~> 1.0)
json (2.7.2)
language_server-protocol (3.17.0.3)
license_finder (7.2.1)
bundler
csv (~> 3.2)
Expand Down Expand Up @@ -127,17 +128,17 @@ GEM
rspec-mocks (~> 3.10)
rspec-support (~> 3.10)
rspec-support (3.13.1)
rubocop (1.52.1)
rubocop (1.66.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.2.2.3)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.28.0, < 2.0)
regexp_parser (>= 2.4, < 3.0)
rubocop-ast (>= 1.32.2, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.31.3)
rubocop-ast (1.32.3)
parser (>= 3.3.1.0)
rubocop-performance (1.21.1)
rubocop (>= 1.48.1, < 2.0)
Expand Down
17 changes: 9 additions & 8 deletions packages/audit_tracker/gemfiles/rails_6_0.gemfile.lock
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
PATH
remote: ../../rubocop-powerhome
specs:
rubocop-powerhome (0.5.2)
rubocop (~> 1.52.0)
rubocop-powerhome (0.5.3)
rubocop (= 1.66.1)
rubocop-performance
rubocop-rails
rubocop-rake
Expand Down Expand Up @@ -93,6 +93,7 @@ GEM
i18n (1.14.5)
concurrent-ruby (~> 1.0)
json (2.7.2)
language_server-protocol (3.17.0.3)
license_finder (7.2.1)
bundler
csv (~> 3.2)
Expand Down Expand Up @@ -189,17 +190,17 @@ GEM
rspec-mocks (~> 3.10)
rspec-support (~> 3.10)
rspec-support (3.13.1)
rubocop (1.52.1)
rubocop (1.66.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.2.2.3)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.28.0, < 2.0)
regexp_parser (>= 2.4, < 3.0)
rubocop-ast (>= 1.32.2, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.31.3)
rubocop-ast (1.32.3)
parser (>= 3.3.1.0)
rubocop-capybara (2.20.0)
rubocop (~> 1.41)
Expand Down
17 changes: 9 additions & 8 deletions packages/audit_tracker/gemfiles/rails_6_1.gemfile.lock
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
PATH
remote: ../../rubocop-powerhome
specs:
rubocop-powerhome (0.5.2)
rubocop (~> 1.52.0)
rubocop-powerhome (0.5.3)
rubocop (= 1.66.1)
rubocop-performance
rubocop-rails
rubocop-rake
Expand Down Expand Up @@ -97,6 +97,7 @@ GEM
i18n (1.14.5)
concurrent-ruby (~> 1.0)
json (2.7.2)
language_server-protocol (3.17.0.3)
license_finder (7.2.1)
bundler
csv (~> 3.2)
Expand Down Expand Up @@ -193,17 +194,17 @@ GEM
rspec-mocks (~> 3.10)
rspec-support (~> 3.10)
rspec-support (3.13.1)
rubocop (1.52.1)
rubocop (1.66.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.2.2.3)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.28.0, < 2.0)
regexp_parser (>= 2.4, < 3.0)
rubocop-ast (>= 1.32.2, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.31.3)
rubocop-ast (1.32.3)
parser (>= 3.3.1.0)
rubocop-capybara (2.20.0)
rubocop (~> 1.41)
Expand Down
17 changes: 9 additions & 8 deletions packages/audit_tracker/gemfiles/rails_7_0.gemfile.lock
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
PATH
remote: ../../rubocop-powerhome
specs:
rubocop-powerhome (0.5.2)
rubocop (~> 1.52.0)
rubocop-powerhome (0.5.3)
rubocop (= 1.66.1)
rubocop-performance
rubocop-rails
rubocop-rake
Expand Down Expand Up @@ -103,6 +103,7 @@ GEM
i18n (1.14.5)
concurrent-ruby (~> 1.0)
json (2.7.2)
language_server-protocol (3.17.0.3)
license_finder (7.2.1)
bundler
csv (~> 3.2)
Expand Down Expand Up @@ -199,17 +200,17 @@ GEM
rspec-mocks (~> 3.10)
rspec-support (~> 3.10)
rspec-support (3.13.1)
rubocop (1.52.1)
rubocop (1.66.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.2.2.3)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.28.0, < 2.0)
regexp_parser (>= 2.4, < 3.0)
rubocop-ast (>= 1.32.2, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.31.3)
rubocop-ast (1.32.3)
parser (>= 3.3.1.0)
rubocop-capybara (2.20.0)
rubocop (~> 1.41)
Expand Down
14 changes: 6 additions & 8 deletions packages/audit_tracker/spec/internal/config/initializers/audit_tracker.rb
View file
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
# frozen_string_literal: true

# rubocop:disable RSpec/FactoryBot/ConsistentParenthesesStyle
AuditTracker.setup do
tracker(:user) do
create :created_by, foreign_key: :created_by_id, class_name: "::Internal::User"
update :updated_by, foreign_key: :updated_by_id, class_name: "::Internal::User"
create(:created_by, foreign_key: :created_by_id, class_name: "::Internal::User")
update(:updated_by, foreign_key: :updated_by_id, class_name: "::Internal::User")
value { Internal::Current.user }
end

tracker(:department) do
create :created_by_department, foreign_key: :created_by_department_id,
create(:created_by_department, foreign_key: :created_by_department_id,
class_name: "::Internal::Department",
value: ->(object) { object&.created_by&.department }
update :updated_by_department, foreign_key: :updated_by_department_id,
value: ->(object) { object&.created_by&.department })
update(:updated_by_department, foreign_key: :updated_by_department_id,
class_name: "::Internal::Department",
value: ->(object) { object&.updated_by&.department }
value: ->(object) { object&.updated_by&.department })
end
end
# rubocop:enable RSpec/FactoryBot/ConsistentParenthesesStyle
17 changes: 9 additions & 8 deletions packages/camel_trail/Gemfile.lock
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
PATH
remote: ../rubocop-powerhome
specs:
rubocop-powerhome (0.5.2)
rubocop (~> 1.52.0)
rubocop-powerhome (0.5.3)
rubocop (= 1.66.1)
rubocop-performance
rubocop-rails
rubocop-rake
Expand Down Expand Up @@ -122,6 +122,7 @@ GEM
rdoc (>= 4.0.0)
reline (>= 0.4.2)
json (2.7.2)
language_server-protocol (3.17.0.3)
license_finder (7.2.1)
bundler
csv (~> 3.2)
Expand Down Expand Up @@ -236,17 +237,17 @@ GEM
rspec-mocks (~> 3.10)
rspec-support (~> 3.10)
rspec-support (3.13.1)
rubocop (1.52.1)
rubocop (1.66.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.2.2.3)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.28.0, < 2.0)
regexp_parser (>= 2.4, < 3.0)
rubocop-ast (>= 1.32.2, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.31.3)
rubocop-ast (1.32.3)
parser (>= 3.3.1.0)
rubocop-performance (1.21.1)
rubocop (>= 1.48.1, < 2.0)
Expand Down
17 changes: 9 additions & 8 deletions packages/camel_trail/gemfiles/rails_6_0.gemfile.lock
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
PATH
remote: ../../rubocop-powerhome
specs:
rubocop-powerhome (0.5.2)
rubocop (~> 1.52.0)
rubocop-powerhome (0.5.3)
rubocop (= 1.66.1)
rubocop-performance
rubocop-rails
rubocop-rake
Expand Down Expand Up @@ -95,6 +95,7 @@ GEM
i18n (1.14.5)
concurrent-ruby (~> 1.0)
json (2.7.2)
language_server-protocol (3.17.0.3)
license_finder (7.2.1)
bundler
csv (~> 3.2)
Expand Down Expand Up @@ -193,17 +194,17 @@ GEM
rspec-mocks (~> 3.10)
rspec-support (~> 3.10)
rspec-support (3.13.1)
rubocop (1.52.1)
rubocop (1.66.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.2.2.3)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.28.0, < 2.0)
regexp_parser (>= 2.4, < 3.0)
rubocop-ast (>= 1.32.2, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.31.3)
rubocop-ast (1.32.3)
parser (>= 3.3.1.0)
rubocop-capybara (2.20.0)
rubocop (~> 1.41)
Expand Down
17 changes: 9 additions & 8 deletions packages/camel_trail/gemfiles/rails_6_1.gemfile.lock
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
PATH
remote: ../../rubocop-powerhome
specs:
rubocop-powerhome (0.5.2)
rubocop (~> 1.52.0)
rubocop-powerhome (0.5.3)
rubocop (= 1.66.1)
rubocop-performance
rubocop-rails
rubocop-rake
Expand Down Expand Up @@ -99,6 +99,7 @@ GEM
i18n (1.14.5)
concurrent-ruby (~> 1.0)
json (2.7.2)
language_server-protocol (3.17.0.3)
license_finder (7.2.1)
bundler
csv (~> 3.2)
Expand Down Expand Up @@ -197,17 +198,17 @@ GEM
rspec-mocks (~> 3.10)
rspec-support (~> 3.10)
rspec-support (3.13.1)
rubocop (1.52.1)
rubocop (1.66.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.2.2.3)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.28.0, < 2.0)
regexp_parser (>= 2.4, < 3.0)
rubocop-ast (>= 1.32.2, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.31.3)
rubocop-ast (1.32.3)
parser (>= 3.3.1.0)
rubocop-capybara (2.20.0)
rubocop (~> 1.41)
Expand Down
17 changes: 9 additions & 8 deletions packages/camel_trail/gemfiles/rails_7_1.gemfile.lock
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
PATH
remote: ../../rubocop-powerhome
specs:
rubocop-powerhome (0.5.2)
rubocop (~> 1.52.0)
rubocop-powerhome (0.5.3)
rubocop (= 1.66.1)
rubocop-performance
rubocop-rails
rubocop-rake
Expand Down Expand Up @@ -122,6 +122,7 @@ GEM
rdoc (>= 4.0.0)
reline (>= 0.4.2)
json (2.7.2)
language_server-protocol (3.17.0.3)
license_finder (7.2.1)
bundler
csv (~> 3.2)
Expand Down Expand Up @@ -232,17 +233,17 @@ GEM
rspec-mocks (~> 3.10)
rspec-support (~> 3.10)
rspec-support (3.13.1)
rubocop (1.52.1)
rubocop (1.66.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.2.2.3)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.28.0, < 2.0)
regexp_parser (>= 2.4, < 3.0)
rubocop-ast (>= 1.32.2, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.31.3)
rubocop-ast (1.32.3)
parser (>= 3.3.1.0)
rubocop-capybara (2.20.0)
rubocop (~> 1.41)
Expand Down
1 change: 1 addition & 0 deletions packages/camel_trail/spec/dummy/config/initializers/inflections.rb
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# frozen_string_literal: true

# Be sure to restart your server when you modify this file.

# Add new inflection rules using the following format
Expand Down
1 change: 1 addition & 0 deletions packages/camel_trail/spec/dummy/config/initializers/mime_types.rb
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# frozen_string_literal: true

# Be sure to restart your server when you modify this file.

# Add new mime types for use in respond_to blocks:
Expand Down
Loading

0 comments on commit d60d935

Please sign in to comment.