Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1724] Dark Mode - Map Audit #4154

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

gabbymassaro
Copy link
Contributor

What does this PR do? A clear and concise description with your runway ticket url.
PLAY-1724

This PR is a part of the Dark Mode Audit on 'Map'.
We've updated the pop up content, it should display a dark background and white text.
Light mode was also impacted to create this change, the functionality remains the same.

Screenshots: Screenshots to visualize your addition/change
403572936-e4954b35-59f1-43cb-814d-117a952b1a0b

How to test? Steps to confirm the desired behavior:

  1. Go to playbook.powerapp.cloud/kits/map/react
  2. Enable 'dark mode'
  3. Check each map
  4. Click on the location icon on the map --> all pop up content should have a dark background and white text
  5. Enable 'light mode', make sure the pop up content behaves the same way as production

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@gabbymassaro gabbymassaro added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target labels Jan 22, 2025
@gabbymassaro gabbymassaro self-assigned this Jan 22, 2025
@gabbymassaro gabbymassaro requested a review from a team as a code owner January 22, 2025 17:04
@nidaqg nidaqg added milano 20 MAX - Deploy this PR to a review environment via Milano Inactive RC Skip the release candidate process and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Jan 22, 2025
Copy link
Contributor

@kangaree kangaree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Good work!

An aside- I wonder if we should move this file to playbook-website/app/javascript/site_styles. I'm not sure this warrants its own folder "map_styles". Or maybe we could change the directory to "kit_styles".

Copy link
Contributor

@nidaqg nidaqg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Awesome work @gabbymassaro !

@nidaqg nidaqg added Code Approved Approved by a Playbook Admin Ready for Release merged to master, ready for a versioned released Product Approved pending technical review, OK to merge to master labels Jan 23, 2025
@jasperfurniss jasperfurniss merged commit a474767 into master Jan 23, 2025
24 checks passed
@jasperfurniss jasperfurniss deleted the play-1724-map-dark-mode-audit branch January 23, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) Inactive RC Skip the release candidate process milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target Product Approved pending technical review, OK to merge to master Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants