Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1751] Convert Kits to Use pb_content_tag (File Upload, Filter, Form Group, and Form Pill) #4153

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

kangaree
Copy link
Contributor

What does this PR do? A clear and concise description with your runway ticket url.
Update File Upload, Filter, Form Group, and Form Pill kits to no longer use "content_tag" and use our new "pb_content_tag".

How to test? Steps to confirm the desired behavior:

  1. Test Rails File Upload, Filter, Form Group, and Form Pill kits on Playbook website.
  2. Test uses on Nitro.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

@kangaree kangaree added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano alpha minor Semver Target labels Jan 22, 2025
@kangaree kangaree requested a review from a team as a code owner January 22, 2025 17:00
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.11.1.pre.alpha.PLAY1751pbcontenttagpt25529

Your Alpha for NPM is 14.11.1-alpha.PLAY1751pbcontenttagpt25529

@jasperfurniss jasperfurniss added Code Approved Approved by a Playbook Admin and removed Needs Review labels Jan 27, 2025
@nidaqg nidaqg added Product Approved pending technical review, OK to merge to master Ready for Release merged to master, ready for a versioned released labels Jan 30, 2025
@kangaree kangaree merged commit 5d4493b into master Jan 30, 2025
24 checks passed
@kangaree kangaree deleted the PLAY-1751-pb_content_tag-pt2 branch January 30, 2025 19:39
Copy link

You merged this pr to master branch:
- Ruby Gem: 14.13.0.pre.rc.5
- NPM: 14.13.0-rc.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target Product Approved pending technical review, OK to merge to master Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants