Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1766] Icon button rails #4141

Merged
merged 4 commits into from
Jan 24, 2025
Merged

[PLAY-1766] Icon button rails #4141

merged 4 commits into from
Jan 24, 2025

Conversation

markdoeswork
Copy link
Contributor

@markdoeswork markdoeswork commented Jan 21, 2025

What does this PR do? A clear and concise description with your runway ticket url.
Runway https://runway.powerhrg.com/backlog_items/PLAY-1766

Adds a new rails only kit for a square style icon button

Its very similar to the circle icon button

Its still in beta, just made a "default" and "link" variant

Check it out here https://pr4141.playbook.beta.px.powerapp.cloud/kits/icon_button

screenshot-pr4141_playbook_beta_px_powerapp_cloud-2025_01_21-10_09_31

@markdoeswork markdoeswork added the milano 20 MAX - Deploy this PR to a review environment via Milano label Jan 21, 2025
@markdoeswork markdoeswork self-assigned this Jan 21, 2025
@markdoeswork markdoeswork added minor Semver Target enhancement New Features, Props, & Variants (USED IN CHANGELOG) labels Jan 21, 2025
@markdoeswork markdoeswork marked this pull request as ready for review January 21, 2025 14:58
@markdoeswork markdoeswork requested a review from a team as a code owner January 21, 2025 14:58
jasperfurniss
jasperfurniss previously approved these changes Jan 22, 2025
nidaqg
nidaqg previously approved these changes Jan 22, 2025
@jasperfurniss jasperfurniss added Code Approved Approved by a Playbook Admin and removed Needs Review labels Jan 22, 2025
@markdoeswork markdoeswork dismissed stale reviews from nidaqg and jasperfurniss via ecad79a January 22, 2025 22:08
@nidaqg nidaqg added Ready for Release merged to master, ready for a versioned released Product Approved pending technical review, OK to merge to master Inactive RC Skip the release candidate process labels Jan 23, 2025
@nidaqg nidaqg added new kit Use this when adding a new kit to Playbook (USED IN CHANGELOG) and removed enhancement New Features, Props, & Variants (USED IN CHANGELOG) labels Jan 24, 2025
@nidaqg nidaqg merged commit 57f235b into master Jan 24, 2025
16 checks passed
@nidaqg nidaqg deleted the play/1766_icon_button_rails branch January 24, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin Inactive RC Skip the release candidate process milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target new kit Use this when adding a new kit to Playbook (USED IN CHANGELOG) Product Approved pending technical review, OK to merge to master Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants