Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-1796] Dark Audit Multiple Users #4139

Merged
merged 7 commits into from
Jan 24, 2025
Merged

[PLAY-1796] Dark Audit Multiple Users #4139

merged 7 commits into from
Jan 24, 2025

Conversation

yuriyivanenko
Copy link
Contributor

@yuriyivanenko yuriyivanenko commented Jan 20, 2025 •
edited
Loading

What does this PR do? A clear and concise description with your runway ticket url.
This PR adds dark mode to the number badge that goes along with Multiple Users kit. We change the color of the badges halo from light to dark for both react & rails.

Screenshots: Screenshots to visualize your addition/change
Screenshot 2025-01-20 at 3 27 14 PM

How to test? Steps to confirm the desired behavior:

  1. Go to the deployed env
  2. Search for 'Multiple Users
  3. For both Rails/React switch to dark mode
  4. See the badge '+2' change from a light border to dark.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@yuriyivanenko yuriyivanenko added the improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) label Jan 20, 2025
@yuriyivanenko yuriyivanenko self-assigned this Jan 20, 2025
@yuriyivanenko yuriyivanenko added enhancement New Features, Props, & Variants (USED IN CHANGELOG) minor Semver Target milano 20 MAX - Deploy this PR to a review environment via Milano and removed improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Jan 20, 2025
@yuriyivanenko yuriyivanenko marked this pull request as ready for review January 20, 2025 20:30
@yuriyivanenko yuriyivanenko requested a review from a team as a code owner January 20, 2025 20:30
@nidaqg nidaqg added Code Approved Approved by a Playbook Admin Inactive RC Skip the release candidate process Ready for Release merged to master, ready for a versioned released Product Approved pending technical review, OK to merge to master and removed Needs Review labels Jan 23, 2025
@nidaqg nidaqg merged commit b4c2e7f into master Jan 24, 2025
16 checks passed
@nidaqg nidaqg deleted the play-1796-dark-audit-multiple-users branch January 24, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss left review comments

@nidaqg nidaqg nidaqg approved these changes

@kangaree kangaree kangaree approved these changes

Assignees

@yuriyivanenko yuriyivanenko

Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) Inactive RC Skip the release candidate process milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target Product Approved pending technical review, OK to merge to master Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuriyivanenko @jasperfurniss @kangaree @nidaqg