[PLAY-1724] DARK MODE AUDIT - Map #4126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabbymassaro
added
bug
jasperfurniss
previously approved these changes
Jan 15, 2025
gabbymassaro
dismissed stale reviews from jasperfurniss and kangaree
via
24387cf
kangaree
previously approved these changes
Jan 16, 2025
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.11.1.pre.alpha.play1724darkmodeauditmap5409 Your Alpha for NPM is 14.11.1-alpha.play1724darkmodeauditmap5409 |
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.11.1.pre.alpha.play1724darkmodeauditmap5413 Your Alpha for NPM is 14.11.1-alpha.play1724darkmodeauditmap5413 |
jasperfurniss
previously approved these changes
Jan 16, 2025
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.11.1.pre.alpha.play1724darkmodeauditmap5437 Your Alpha for NPM is 14.11.1-alpha.play1724darkmodeauditmap5437 |
gabbymassaro
removed
the
milano
gabbymassaro
dismissed stale reviews from jasperfurniss and kangaree
via
df961ad
|
We're going with another solution that is less invasive. I'll be closing this PR to open a fresh one with the simplified code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
PLAY-1724
This PR is a part of the Dark Mode Audit on 'Map'.
We've updated the pop up content, it should display a dark background and white text.
Light mode was also impacted to create this change, the functionality remains the same.
Screenshots: Screenshots to visualize your addition/change
Before (left) and After (right)
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.