Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1351] Upgrade Highcharts #3427

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

markdoeswork
Copy link
Contributor

@markdoeswork markdoeswork commented May 22, 2024

What does this PR do? A clear and concise description with your runway ticket url.

Runway https://nitro.powerhrg.com/runway/backlog_items/PLAY-1351

Upgrades highcharts from version 9 to 10

I added the boiler plate for tests for the graphs because they had nothing. I would have liked to add snapshot testing but was having issues because highcharts generates random ids for different parts of the graphs

your suppose to be able to do things like expect.any(String) https://jestjs.io/docs/snapshot-testing#property-matchers But you need to download other library(s) to get it to work. I bailed because its out of scope

other people have this issue enzymejs/enzyme#1050

test('bargraph has right html structure', () => {
  const { container } = render(
    <BarGraph
      data={{ testid: testId }}
    />
  );
  
  expect(container).toMatchSnapshot({ id: expect.any(String) });
});

Screenshot 2024-05-24 at 9 43 20 AM

How to test? Steps to confirm the desired behavior:
Everything should be the same, just a version bump

@markdoeswork markdoeswork self-assigned this May 22, 2024
@markdoeswork markdoeswork added the milano 20 MAX - Deploy this PR to a review environment via Milano label May 24, 2024
@markdoeswork markdoeswork marked this pull request as ready for review May 24, 2024 13:46
@markdoeswork markdoeswork requested review from a team as code owners May 24, 2024 13:46
@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label May 31, 2024
@thestephenmarshall thestephenmarshall added this pull request to the merge queue Jun 3, 2024
Merged via the queue into master with commit 7bfb30d Jun 3, 2024
6 checks passed
@thestephenmarshall thestephenmarshall deleted the play/1351_upgrade_highcharts branch June 3, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants