Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-288] Table kit subcomponent alignment + shift #3426

Merged

Conversation

nickamantia
Copy link
Contributor

@nickamantia nickamantia commented May 22, 2024

PBNTR-288

This PR:

  • Updates doc examples to use new subcomponent syntax.
    -Alignment and Shift variants now use global props instead of attributes

  • Adds new vertialAlign global prop

Screenshot 2024-05-22 at 3 00 27 PM

How to test? Steps to confirm the desired behavior:

  1. Go to the Table kit and confirm example are correct.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nickamantia nickamantia self-assigned this May 22, 2024
@nickamantia nickamantia added milano 20 MAX - Deploy this PR to a review environment via Milano enhancement New Features, Props, & Variants (USED IN CHANGELOG) labels May 22, 2024
@nickamantia nickamantia marked this pull request as ready for review May 22, 2024 18:55
@nickamantia nickamantia requested review from a team as code owners May 22, 2024 18:55
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-288-table-kit-subcomponenet-alignment-and-shift

@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label May 31, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue May 31, 2024
Merged via the queue into master with commit da78002 May 31, 2024
6 checks passed
@jasperfurniss jasperfurniss deleted the pbntr-288-table-kit-subcomponenet-alignment-and-shift branch May 31, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants