-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PBNTR-288] Table kit subcomponent alignment + shift #3426
Merged
jasperfurniss
merged 19 commits into
master
from
pbntr-288-table-kit-subcomponenet-alignment-and-shift
May 31, 2024
Merged
[PBNTR-288] Table kit subcomponent alignment + shift #3426
jasperfurniss
merged 19 commits into
master
from
pbntr-288-table-kit-subcomponenet-alignment-and-shift
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickamantia
added
milano
20 MAX - Deploy this PR to a review environment via Milano
enhancement
New Features, Props, & Variants (USED IN CHANGELOG)
labels
May 22, 2024
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-288-table-kit-subcomponenet-alignment-and-shift |
co1in-1ewis
added
the
Product Approved
pending technical review, OK to merge to master
label
May 31, 2024
jasperfurniss
approved these changes
May 31, 2024
jasperfurniss
deleted the
pbntr-288-table-kit-subcomponenet-alignment-and-shift
branch
May 31, 2024 18:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New Features, Props, & Variants (USED IN CHANGELOG)
milano
20 MAX - Deploy this PR to a review environment via Milano
Product Approved
pending technical review, OK to merge to master
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBNTR-288
This PR:
Updates doc examples to use new subcomponent syntax.
-Alignment and Shift variants now use global props instead of attributes
Adds new
vertialAlign
global propHow to test? Steps to confirm the desired behavior:
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.