JIT: Support block statements #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
let_statements_in_block
branch
from
d73c3d4 to
f4e2824
Compare
chriseth
force-pushed
the
let_statements_in_block
branch
2 times, most recently
from
1c9fefe to
1a383f3
Compare
chriseth
force-pushed
the
let_statements_in_block
branch
from
1a383f3 to
b24ee27
Compare
chriseth
commented
Oct 2, 2024
| .unwrap_or_default(); | ||
|
|
||
| let (vars, code) = check_pattern(var_name, pattern)?; | ||
| // TODO if we want to explicitly specify the type, we need to exchange the non-captured |
There was a problem hiding this comment.
This is just a note in case we need it in the future if rust cannot determine the type.
There was a problem hiding this comment.
I don't understand this comment. It is talking about the type of {vars} , I assume. But what are the non-captured parts that must be exchanged by ()?
lvella
approved these changes
Oct 2, 2024
|
I'll create a follow-up PR to extend the todo. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.