Rewrite Makefile #245
Merged
Rewrite Makefile #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP:
But all the rest should be good. Try |
cyqsimon
commented
Oct 7, 2024
- Binary generation done - Release archive generation done
cyqsimon
commented
Oct 8, 2024
This is not intended to stay. Will refactor in a separate PR.
|
Hi @cyqsimon, I will review this soon. Have been a bit busy past few days |
pouriyajamshidi
requested changes
Oct 11, 2024
There was a problem hiding this comment.
Also, can we add support for darwin-x86 to close off Please provide static build for windows-arm64, linux-arm64, darwin-x86 · Issue #243 · pouriyajamshidi/tcping (github.com)?
Thanks in advance
Otherwise `pushd` and `popd` won't work. Co-authored-by: Pouriya Jamshidi <[email protected]>
cyqsimon
commented
Oct 12, 2024
pouriyajamshidi
previously approved these changes
Oct 12, 2024
pouriyajamshidi
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Rewrite Makefile to rely less on
.PHONYtargets.While working on the logic problem in #242, I found the current Makefile setup to be quite clumsy. No offence to the previous author, but it seems to me that it's quite hastily cobbled together. Lots of unnecessary code duplication and under-utilisation of the strengths of make (specifically, its focus on file generation).
So I decided to overhaul the whole thing. A bit drastic, but I believe it's for a good cause.
Issue ticket number and link
Closes #242.
Checklist before requesting a review
make checkand there are no failures.Type of change
Please delete options that are not relevant.